Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] drm/amd/display: Fix gcc unused variable warning
To:     Pu Lehui <pulehui@huawei.com>, sunpeng.li@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch,
        Jun.Lei@amd.com, wenjing.liu@amd.com, Anson.Jacob@amd.com,
        qingqing.zhuo@amd.com, Wesley.Chalmers@amd.com,
        Jimmy.Kizito@amd.com, aric.cyr@amd.com, martin.tsai@amd.com,
        jinlong.zhang@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, zhangjinhao2@huawei.com
References: <20210617023109.204591-1-pulehui@huawei.com>
From:   Harry Wentland <harry.wentland@amd.com>
Message-ID: <fa86062f-cb45-245b-1bf0-494ffcd33908@amd.com>
Date:   Thu, 17 Jun 2021 14:42:52 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
In-Reply-To: <20210617023109.204591-1-pulehui@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.50.3] (198.200.67.154) by QB1PR01CA0018.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:2d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.16 via Frontend Transport; Thu, 17 Jun 2021 18:42:55 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e33c9223-13b9-4054-4711-08d931bfb9ca
X-MS-TrafficTypeDiagnostic: CO6PR12MB5476:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO6PR12MB5476A76C5B0F3355EEA97B1B8C0E9@CO6PR12MB5476.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: OiFbC5H6bIZHDDw1eYDXSPQySlTMdrWwC624sJsHUfHjqB+v71uaZYhZUra0okFxWkwDJrZR2rJhckgv+/2mxmz0/W8vQcY/34scasp03mun/oGowuT2flLvhZzdYHx1Z7rctVaYS3YZQRRFD7zL7EOwmxKg/9VFpDBXMkqm0QlBZhv6qp4mXEP1LDrR8tYjZPnTk9pTMT2GMRq+5dMZTGNQSchaeFwJ68y2b9dBKio3TYQMjpklTpngoQU4bI2PkNvh+wzXJiT5pB6PJ9YR+glN0MY2gTw5thzTTgvj8wMZHSAyv1hm8tKePwWH/vAS5BB7OBmiZHGQ7hFQVM13JOAT9Vb4Six3EF6jtibBUgnFb0sMddNgBsB61gKasrrPuNuzMXFcZQfOF7r1+3ozfV7+IC8PM18DzgvNIeE58lA1OoROhAgBELjkRJEkOXD0wAV7wdMX9MKP/uGJT/+eUeMOtVH0BRTCp45WBROcS6q+sarDCmR91DufFUDk9z2tqR9aQ/auZ3O9cfD6Y3xaewf+p2hRY5zd3Ddx+CPJQCoWwDm+PY8SUJXScE2Mlfal5RuXtF5WnFtifqegPXuUqTHgLoGRjUzHIifS8gfnPF/z90OOUip2ZKW1FYMJKDjwbGu7Q5gOUn0M+Y14L4lp3Zg5stLqbSc1jfkF1fU+IRRy/u8439qXApNT3cv7rkv6L3Srki+L3tUOgG+CkIzROg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO6PR12MB5427.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(366004)(376002)(39860400002)(2616005)(956004)(31696002)(478600001)(8676002)(26005)(5660300002)(921005)(186003)(38100700002)(36756003)(4326008)(2906002)(6636002)(44832011)(66476007)(16526019)(66556008)(53546011)(316002)(31686004)(6666004)(86362001)(6486002)(83380400001)(66946007)(16576012)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODhqZWtPWGhCZlF6MGo0cVI3YURUajN0UUVoZkhFVzlob3JCd09NM3RSUHlR?=
 =?utf-8?B?eXZKL01EYThKMU95aHNmRkVMTGNub1VXbXJMMDEvb1NoQTJtMXBRSWZMWGsr?=
 =?utf-8?B?T2s4VzNQejNvbmtrbHpTVVBjMWFITFBNSjVTRjJqWUFuZEtxWStodHNnRmRN?=
 =?utf-8?B?NDRiazBWWDBHK0VhUFVhdzB1RENRd1FKZGdjR0xHYmpIWDBDY2kzUkNSYVd0?=
 =?utf-8?B?VjZHTXhKdGdOd2RGSnY4TlpvVmtzcndjNjE3OG9aR1pKamV2MGZ3bGRGenBK?=
 =?utf-8?B?anUwMUh3bHNhdFhBTUF0Um16Z2IrZkFUS1QwMG1aSENBS1c1SUlEb1pQd2th?=
 =?utf-8?B?MWt5Q1JJSnBQWVh4WkgyMHo0OUJ5NloydmFZbS9hNHRHWVpEemRaYitINFdT?=
 =?utf-8?B?NGx1OEYrSjdlTlpWYk45eUpIbUh3QjFORzJ2VnQrb3lqQXZ5QmVRRmYzMVdQ?=
 =?utf-8?B?RVZML2JrVW80akNEK2FKYUtaRkhMeStYYVU0ZHdhMk0wVWlyVzRXRlYzUW5Y?=
 =?utf-8?B?T1gxR01TK1lGNncyL0xFT2ZBbHljZWVhczdydDljWjkvZzdxZzFFb0gwSnlx?=
 =?utf-8?B?YlRVNHV1YlE4T3J4Ky9ZZTE2S2RSakVFOTNIbksrci9SMCs4YnppV095ZWx2?=
 =?utf-8?B?Z2owZUdldTE0MXFnVGN5UFpETHlTNmpnbkNKWjk5bThTUlhpWkJ6Ym9xTzha?=
 =?utf-8?B?Z2xIa3V1QjVPSzV0aHltc1piV2dDbmliWVhvZHA2RnVTNEtja2ZrS0d3RVNU?=
 =?utf-8?B?T041Wmh5Wkh3RFNIZXFZYXRHeU9YTHZIZFQrVkZmOXpnbTQzaTRycHZUZFJx?=
 =?utf-8?B?cVdCYWF2UWI3d2VzWWpqbERWT0Vja2RjU0Rnem9xSHRGSmxNaC9qN2Q4bmpO?=
 =?utf-8?B?YWptbVdYYkJnaktJUGdiSWVYS0k5L0pEQi9YNTlqTHVzeTNjUFV1Z2RwdEtG?=
 =?utf-8?B?ZFVwUGJJd0hXMjZpaFNXaEN2bkZQWGJmMVBZblFHUWF1eVV3OUF5NE0vcjJn?=
 =?utf-8?B?ZzJ2Wjk3RTRGM3ErSkpkOTJFcDgzaTErRkZlQ1RwMmlGVmpNQmtxZkJVWmRp?=
 =?utf-8?B?RjlTL3ZuUG4rc2JQcU84YWhCdTZEcGpZWVhkK0FBMytaYko3ZnB5TE9pb3E3?=
 =?utf-8?B?UWJoNDRzUU9uaGFzaFkyMk4rNmpuZGN2b0Vzd1ZUTTBvRW5kU0c2UGFVMGt3?=
 =?utf-8?B?cFoyeE5NUDhOTzdHZGY0UmJwNmx4NFY4ZEhiVy9rQ2xtVDdwd1JPVHdjK3ZD?=
 =?utf-8?B?Rm1sRWR6REtmRUgrRWhVWXB3U21OYS8yWE5zVktRb1hSN3FWNmtraXZjaER6?=
 =?utf-8?B?Q05BOHFyaW9OQ2NZVndsdWlwZlFaY3FWbnBGTHgyTFVGYm5jd1J2U2M0R3RY?=
 =?utf-8?B?cjFXeW5kTDV6WVNoSUpVZFZIR1BUeDNTUFBPcUQrSTU5cFRxaVl3dUVPZW9T?=
 =?utf-8?B?MkIzN2lUYjF3VjBiYlU4TkdnQzlUQlNvNFdmME5tN0JTb2ZJYWpWRXVHZkx3?=
 =?utf-8?B?WFNzdy9CUHJaSmc0UUwvRm9maEExRHJ1R0pFQlNLeE0wVFB6czljbXl3RVpL?=
 =?utf-8?B?WXJUNlZPYkRnTVNGeURSZXVPdjYwZXV3bUpoSDlxSkhPK001VW5WTmNqcmU0?=
 =?utf-8?B?bnlrblVpSXR4RXQ3b1Zqb29KVCt4cTZFNzYyZnUxdTBqc0RNR05jdlNFekty?=
 =?utf-8?B?dHRaanV3eTBVRFVRRFFIY2lyakplTi9RT0Y5NmF4ZitLN1h3enVQUlVvOGFl?=
 =?utf-8?Q?+owcren1vR0g7rYEwsifFe0Z/mEUy+Hjf+urTre?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e33c9223-13b9-4054-4711-08d931bfb9ca
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2021 18:42:57.7830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: We6Zbbi91ovJidUhO5cc0MQouqBnlulgc5YzCAdtTITJuSXdqu8CmAiBM9NALmEDPk7dzL0BG8WNprvwmnpKHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5476
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-06-16 10:31 p.m., Pu Lehui wrote:
> GCC reports the following warning with W=1:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3635:17:
> warning:
>  variable ‘status’ set but not used [-Wunused-but-set-variable]
>   3635 |  enum dc_status status = DC_ERROR_UNEXPECTED;
>        |                 ^~~~~~
> 
> The variable should be used for error check, let's fix it.
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index fcb635c85330..cf29265870c8 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -3681,6 +3681,10 @@ bool dp_retrieve_lttpr_cap(struct dc_link *link)
>  				DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV,
>  				lttpr_dpcd_data,
>  				sizeof(lttpr_dpcd_data));
> +		if (status != DC_OK) {
> +			dm_error("%s: Read LTTPR caps data failed.\n", __func__);
> +			return false;
> +		}
>  
>  		link->dpcd_caps.lttpr_caps.revision.raw =
>  				lttpr_dpcd_data[DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV -
>