Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210604190338.2248295-1-martin.blumenstingl@googlemail.com>
 <20210604190338.2248295-2-martin.blumenstingl@googlemail.com> <20210616233109.GA285667@robh.at.kernel.org>
In-Reply-To: <20210616233109.GA285667@robh.at.kernel.org>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Fri, 18 Jun 2021 00:30:02 +0200
Message-ID: <CAFBinCCE8vmMJE-Y0dvGpT+1QFKVN0U9yKinF_2w+644GaXxYg@mail.gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings
To:     Rob Herring <robh@kernel.org>
Cc:     linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        linux-amlogic@lists.infradead.org, kishon@ti.com, vkoul@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Rob,

On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@kernel.org> wrote:
[...]
> > +description: |+
> > +  The HDMI TX PHY node should be the child of a syscon node with the
> > +  required property:
> > +
> > +  compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon"
>
> Is there a sub range of registers for this functionality in
> "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property.
yes, for this part of the HHI registers there's a dedicated sub range.
I'll add a reg property with register offset and size

one question about .dts validation: at least the clock controller
(which is also a sub-node of this) does not have a dedicated sub
range.
Is it still OK in this case to set #size-cells = <1> and
#address-cells = <1> in the HHI node?


Best regards,
Martin