Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1015244pxj; Thu, 17 Jun 2021 20:13:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRVS0o6FvD6+JiPnciz3D6O6n8b35IcJXwt53VFq9MUIRSkdsHIOBk8V/SGGYuXRk7aJMl X-Received: by 2002:aa7:d642:: with SMTP id v2mr1984676edr.267.1623986019278; Thu, 17 Jun 2021 20:13:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623986019; cv=none; d=google.com; s=arc-20160816; b=ADEEPtmzl6AbO3QyyynA+KyBznyRyUnaviTOqtOQIoRTOYFzbP6ftPZyMuCslKFYgn Hmzen1n8fDLXwZkfMlKvOKemAoh5njrvBKlgNHwqAfU1vEbL0zyYsie0XQbYpux2hesS Aw/K3MJWOQ4GvGWMg5vXSUcd4R5zYveG3MW7Y+KX72kY16GBwvelVRjDgwG8ovcJEqEl f9LGRYozIyO0JzW/qUNNnZrGj7NomTLWtty3ZUrbmUoCmu1djPvvXIvIa14wsEYTMN0p J4A+x24/sc/indQxxeCWf0xXkhJdHalEWNpsQRpJJIsKmETKLkcgcr0WWQWb2v+v1kCi X1yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=3iZfGBKh+6XSYEwKfw53fExJs5OXf4aY73/243+p8LU=; b=T8PRvlitsGt2P6ZMbzsJycd4F9geFhSn9b/HDdGTCt73tbnlUtMTIP20cM1/ByGX4V /yDPf+V6TGP/64WWov/6xfnV1V1VolAR8V+/A59T1f69BsFB9mDZC3WKav4hcLhhHGtj XqalSR78hLu+Dnyu6z8M2EPCgPGl1o8/NI0Gs7mQ+y2we1UXUt1F17XO2XeVoYu9kfG/ NfwIHJgjCYk5GRdzRiNPeyJ5QRWq2XxnFJ5nJGSTtcAdQdKOzP03YgrGfGLWJ89hqIxT 4oZ2H7iILNQ4oYmiu34ToXl9sEo1mS8+1ATMJp9bb/fx1rxcBY9F/QVdmxg5IXS1IRoL keWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 20si1149294ejj.363.2021.06.17.20.13.16; Thu, 17 Jun 2021 20:13:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233346AbhFRArd (ORCPT + 99 others); Thu, 17 Jun 2021 20:47:33 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:7478 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233320AbhFRArc (ORCPT ); Thu, 17 Jun 2021 20:47:32 -0400 Received: from dggeme755-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G5g9s5XV1zZhKb; Fri, 18 Jun 2021 08:42:25 +0800 (CST) Received: from [10.67.100.138] (10.67.100.138) by dggeme755-chm.china.huawei.com (10.3.19.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 18 Jun 2021 08:45:22 +0800 Subject: Re: [PATCH net-next 5/6] net: hostess_sv11: fix the comments style issue To: Andrew Lunn CC: , , , , , , , References: <1623941615-26966-1-git-send-email-lipeng321@huawei.com> <1623941615-26966-6-git-send-email-lipeng321@huawei.com> From: "lipeng (Y)" Message-ID: <2ea3967f-b4e4-323b-bf65-aac108c6d27f@huawei.com> Date: Fri, 18 Jun 2021 08:45:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.100.138] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggeme755-chm.china.huawei.com (10.3.19.101) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/6/18 0:29, Andrew Lunn 写道: >> @@ -152,12 +146,12 @@ static int hostess_close(struct net_device *d) >> static int hostess_ioctl(struct net_device *d, struct ifreq *ifr, int cmd) >> { >> /* struct z8530_dev *sv11=dev_to_sv(d); >> - z8530_ioctl(d,&sv11->chanA,ifr,cmd) */ >> + * z8530_ioctl(d,&sv11->chanA,ifr,cmd) >> + */ >> return hdlc_ioctl(d, ifr, cmd); >> } > That looks more like dead code than anything else. I would suggest you > do a git blame to see if there is anything interesting about this, and > if not, remove it. > > Andrew > . Hi,  Andrew It's  dead code,  will remove it. Thanks for your advice.         Peng Li