Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210617150523.454965-1-sxwjean@me.com> <YMtnf4lOEiF++32w@boqun-archlinux>
In-Reply-To: <YMtnf4lOEiF++32w@boqun-archlinux>
From:   Xiongwei Song <sxwjean@gmail.com>
Date:   Fri, 18 Jun 2021 09:50:43 +0800
Message-ID: <CAEVVKH9RQmh7oh-bE4t5AaVYD_Suu+sHAr=WUEHupV1pP7-1GQ@mail.gmail.com>
Subject: Re: [PATCH] locking/lockdep: correct the description error for check_redundant()
To:     Boqun Feng <boqun.feng@gmail.com>
Cc:     Xiongwei Song <sxwjean@me.com>, peterz@infradead.org,
        mingo@redhat.com, will@kernel.org, longman@redhat.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jun 17, 2021 at 11:17 PM Boqun Feng <boqun.feng@gmail.com> wrote:
>
> On Thu, Jun 17, 2021 at 11:05:23PM +0800, Xiongwei Song wrote:
> > From: Xiongwei Song <sxwjean@gmail.com>
> >
> > If there is no matched result, check_redundant() will return BFS_RNOMATCH.
> >
> > Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
>
> Good catch!
>
> Nit: you may want to capitalize the first letter after subsystem tag in
> the patch title, like:
>
>         "locking/lockdep: Correct ..."

Ok. Will update the patch.

>
> Reviewed-by: Boqun Feng <boqun.feng@gmail.com>

Thank you.

Regards,
Xiongwei
>
> Regards,
> Boqun
>
> > ---
> >  kernel/locking/lockdep.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> > index cfe0f4374594..1f126ca7fbd7 100644
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask)
> >   * <target> or not. If it can, <src> -> <target> dependency is already
> >   * in the graph.
> >   *
> > - * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if
> > + * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if
> >   * any error appears in the bfs search.
> >   */
> >  static noinline enum bfs_result
> > --
> > 2.30.2
> >