Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Paul Davey <paul.davey@alliedtelesis.co.nz>
To:     Manivannan Sadhasivam <mani@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paul Davey <paul.davey@alliedtelesis.co.nz>
Subject: [PATCH 1/2] bus: mhi: Fix pm_state conversion to string
Date:   Fri, 18 Jun 2021 15:31:31 +1200
Message-Id: <20210618033132.24839-2-paul.davey@alliedtelesis.co.nz>
In-Reply-To: <20210618033132.24839-1-paul.davey@alliedtelesis.co.nz>
References: <20210618033132.24839-1-paul.davey@alliedtelesis.co.nz>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On big endian architectures the mhi debugfs files which report pm state
give "Invalid State" for all states.

Fix to_mhi_pm_state_str by using a local unsigned long as an intemediate
to pass the state to find_last_bit to avoid endianness issues with cast
from enum mhi_pm_state * to unsigned long *.

Signed-off-by: Paul Davey <paul.davey@alliedtelesis.co.nz>
---
 drivers/bus/mhi/core/init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index c81b377fca8f..87cc0c449078 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -79,7 +79,8 @@ static const char * const mhi_pm_state_str[] =3D {
=20
 const char *to_mhi_pm_state_str(enum mhi_pm_state state)
 {
-	int index =3D find_last_bit((unsigned long *)&state, 32);
+	unsigned long tmp =3D state;
+	int index =3D find_last_bit((unsigned long *)&tmp, 32);
=20
 	if (index >=3D ARRAY_SIZE(mhi_pm_state_str))
 		return "Invalid State";
--=20
2.32.0