Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1294490pxj; Fri, 18 Jun 2021 04:06:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3DYxEfoOpQxqpsHc6CxanE6u0VSO8VF7PrqLF3Yf3ECnCmqq1Iesp35Gn2lhR5cHakVvL X-Received: by 2002:a17:906:d20b:: with SMTP id w11mr10570366ejz.242.1624014406060; Fri, 18 Jun 2021 04:06:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624014406; cv=none; d=google.com; s=arc-20160816; b=pCgSqKl9jFKDGxtkXT8YFebeaB5nqkYZpDxUw8ispTGs8avz/x16LBnjU3+GJG4WHs Axb8NPjs95nToMKIXY4n0fDHcZuVOqFc28XSqhAFJNIob3FQp0IVmQ0OV0YWTVR4woHk 896WHIzamKODDXpAga4S8wlW+H/ZRrj1teT0IcA2J98McDDlNkZjgeiRgaWtI1oxk3dW 7mlBBblj4RBe+t72TOHZ8sqvlKuBXpRik0tRmYH2+D7Qvvy7MQiwTSDzhdCTVSpPtyaZ iXU0XywDVxVejAXD2zeG9hJckx0YoDfvV2lffc/reZ3JBA0vHOn7/eHj+vYOGXJAkkWm 6rWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=OzTYpDpbYOtsnVicXwaElqjRB+NGoP1nUKd3K62V7uk=; b=p0qqtrA2ukVooRjTm4AmEzCGuM1nFhwgpKoxb9oNKFqsuoCsax+KhSJH1fK4HCCsrZ D6jR+xqFYxtU5j6/jkn6Apl9jot+l0UY48tUV17A84reFvQmX3yRzDniIB2eRwiqjm5T 25YusRZRrbmUb0TnOE2iQhv4CzaWZWPt65jn1pj2oZoVqOUFXXSNmSL8eTI4ZBOjI/mR aA7bSlOPW2Hs09hCNmi5FXcBmwihm/p1ifWRkxBzINi84d6xSbThVWiRKJr0HnpJDjvV wfP3kffz5AkvsW47BObatdWAlOBgQmbtmSiXM6FDeWlgIXBV0r2P1Eb5n0wBhzFRGzt0 sSjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t21si7633379edd.423.2021.06.18.04.06.23; Fri, 18 Jun 2021 04:06:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233104AbhFRJNp (ORCPT + 99 others); Fri, 18 Jun 2021 05:13:45 -0400 Received: from srv6.fidu.org ([159.69.62.71]:56534 "EHLO srv6.fidu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232990AbhFRJNo (ORCPT ); Fri, 18 Jun 2021 05:13:44 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by srv6.fidu.org (Postfix) with ESMTP id D2E54C800B9; Fri, 18 Jun 2021 11:11:31 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at srv6.fidu.org Received: from srv6.fidu.org ([127.0.0.1]) by localhost (srv6.fidu.org [127.0.0.1]) (amavisd-new, port 10026) with LMTP id AlHmUsx4l1zF; Fri, 18 Jun 2021 11:11:31 +0200 (CEST) Received: from wsembach-tuxedo.fritz.box (p200300e37f3949001760E5710682cA7E.dip0.t-ipconnect.de [IPv6:2003:e3:7f39:4900:1760:e571:682:ca7e]) (Authenticated sender: wse@tuxedocomputers.com) by srv6.fidu.org (Postfix) with ESMTPA id 5DFBAC800B3; Fri, 18 Jun 2021 11:11:31 +0200 (CEST) From: Werner Sembach To: harry.wentland@amd.com, sunpeng.li@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org Cc: Werner Sembach Subject: [PATCH v4 01/17] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Date: Fri, 18 Jun 2021 11:11:00 +0200 Message-Id: <20210618091116.14428-2-wse@tuxedocomputers.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210618091116.14428-1-wse@tuxedocomputers.com> References: <20210618091116.14428-1-wse@tuxedocomputers.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check that was performed in the drm_mode_is_420_only() case, but not in the drm_mode_is_420_also() && force_yuv420_output case. Without further knowledge if YCbCr 4:2:0 is supported outside of HDMI, there is no reason to use RGB when the display reports drm_mode_is_420_only() even on a non HDMI connection. This patch also moves both checks in the same if-case. This eliminates an extra else-if-case. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6fda0dfb78f8..44757720b15f 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -5353,10 +5353,7 @@ static void fill_stream_properties_from_drm_display_mode( timing_out->v_border_bottom = 0; /* TODO: un-hardcode */ if (drm_mode_is_420_only(info, mode_in) - && stream->signal == SIGNAL_TYPE_HDMI_TYPE_A) - timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420; - else if (drm_mode_is_420_also(info, mode_in) - && aconnector->force_yuv420_output) + || (drm_mode_is_420_also(info, mode_in) && aconnector->force_yuv420_output)) timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420; else if ((connector->display_info.color_formats & DRM_COLOR_FORMAT_YCRCB444) && stream->signal == SIGNAL_TYPE_HDMI_TYPE_A) -- 2.25.1