Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 18 Jun 2021 10:34:09 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc:     linux-kernel@vger.kernel.org,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ingo Molnar <mingo@redhat.com>, Josh Don <joshdon@google.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Mel Gorman <mgorman@suse.de>,
        Qais Yousef <qais.yousef@arm.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Viresh Kumar <viresh.kumar@linaro.org>, rostedt@goodmis.org
Subject: Re: [RFC] schedutil: Fix iowait boost issues for slow I/O devices
Message-ID: <YMxagWy/Ioj3aere@hirez.programming.kicks-ass.net>
References: <20210618040639.3113489-1-joel@joelfernandes.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210618040639.3113489-1-joel@joelfernandes.org>
Precedence: bulk


Aside from everything else:

On Fri, Jun 18, 2021 at 12:06:39AM -0400, Joel Fernandes (Google) wrote:

> +unsigned int sysctl_iowait_reset_ticks = 20;
> +unsigned int sysctl_iowait_apply_ticks = 10;

Never expose HZ to userspace. we even have USER_HZ (no new usage please)
that fixed existing problems with that.

If you expose a knob, make it in sane time units and convert internally
to whatever you need. That said; less is more with knobs.