Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1356694pxj; Fri, 18 Jun 2021 05:32:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwF3N2gdxeuGTtGBpSuvZSpnruU8RwwhKkaQwqnvhh0MswZiqJTPlXbMSxB9Ouywzkd629K X-Received: by 2002:a05:6402:1ac9:: with SMTP id ba9mr4755279edb.250.1624019545123; Fri, 18 Jun 2021 05:32:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624019545; cv=none; d=google.com; s=arc-20160816; b=wu6xzZ++O7BfHoTb2v3RI8ZD9U06O+hUbBXy1Rdb2foY1eEp3/pEPJ0a0uekDLTLFj Fkh4WqUglwN27ZY0D8Fh3YSmne15MCb+pI6ONxxZUoeX264fgmIKZ13kdkTMobJO8rTb ih7RgDbTRlAGdhOHpZ7ASm8opbiHmvCgUfndgRjssRx5cYOXWlSBcssa9W53aIxY51aq Ic1/MR1GM1AZw2Srd2D6OCn28lVIFWoJNFo9zaZHApH7X7bQWE5ILjFHQQhX1DW8O+Ix L3bc6qQR6WHj2leQgrWnV/+DmwvxkijWL/Y9qNMDU/Mi5Gj54IXgr3I0CpUcP3sK9v7W XN0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=F/QFUrwF094CrIarbyITIlpIz9bLRh0f5Z3rWQyDB6E=; b=FfW/v41WRx4rEZ+RVEIgvtAhe+h8PTQg1yLb1UQN90laT79376SUghRTvmo21VWYOa DyYE+ok07Wt1vf4mywSpf0tyeXetKTztHc0f5S+PVUmFllWWpGJmKZ+zHuiYt5c3ECou jErJv7dcFDUSPNz5m9SG+9xCJtxu7+DwxhbfpNofosC3LpZHkaHt3UOVEdDat3THzEAB UexA/+Oqta5Vbj78kKFeCRi+x0kd5FTCWm6GhOO6mSRf48RT+CDevbU/8DN+BGD4txQU DdG4dZLQVZKTM41IKuEAVxP6x73PbLR8RXSfchLLy3lccumx5q9dZdF5JpeB2tqZ3n4l iV6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BbweEaz3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y8si8846003edc.556.2021.06.18.05.32.01; Fri, 18 Jun 2021 05:32:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BbweEaz3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbhFRK0u (ORCPT + 99 others); Fri, 18 Jun 2021 06:26:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:46118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230340AbhFRK0t (ORCPT ); Fri, 18 Jun 2021 06:26:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 87F616117A; Fri, 18 Jun 2021 10:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624011879; bh=D4AuELaLNiFNv3CP+vGfYuaFK7KeBacpL83m0TZ33VE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BbweEaz375f0SKyqNBp8/jwO5GQ0a4ahI+O21R6sJZvmUaP8DZVAPQ9mZi/kseyO2 7/KnqM3ZhcZIUU1mTpSEPgsA4v+cH+rBy8mEV/v4m9PRjpFcL1oS9sfmZUZWeiWgE9 TeAMkNZID6ErNSCd6GM1ObsAemliqy1uVv7CZbUc= Date: Fri, 18 Jun 2021 12:24:36 +0200 From: Greg KH To: Amit Klein Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, edumazet@google.com, w@1wt.eu, davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH 4.14] inet: use bigger hash table for IP ID generation (backported to 4.14) Message-ID: References: <60cc6c9a.1c69fb81.70a57.7034@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60cc6c9a.1c69fb81.70a57.7034@mx.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 18, 2021 at 02:51:22AM -0700, Amit Klein wrote: > Subject: inet: use bigger hash table for IP ID generation (backported to 4.14) > From: Amit Klein > > This is a backport to 4.14 of the following patch, originally > developed by Eric Dumazet. > > In commit 73f156a6e8c1 ("inetpeer: get rid of ip_id_count") > I used a very small hash table that could be abused > by patient attackers to reveal sensitive information. > > Switch to a dynamic sizing, depending on RAM size. > > Typical big hosts will now use 128x more storage (2 MB) > to get a similar increase in security and reduction > of hash collisions. > > As a bonus, use of alloc_large_system_hash() spreads > allocated memory among all NUMA nodes. > > Fixes: 73f156a6e8c1 ("inetpeer: get rid of ip_id_count") > Reported-by: Amit Klein > Cc: stable@vger.kernel.org > Cc: Eric Dumazet > Cc: Willy Tarreau > --- What is the git commit id of this patch in Linus's tree? thanks, greg k-h