Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <60cc6c9a.1c69fb81.70a57.7034@mx.google.com> <YMx0ZIAkTloug34m@kroah.com>
In-Reply-To: <YMx0ZIAkTloug34m@kroah.com>
From:   Amit Klein <aksecurity@gmail.com>
Date:   Fri, 18 Jun 2021 13:29:23 +0300
Message-ID: <CANEQ_+JLe-nA=7T+_nQgfwJMe4OBz+8MRo1kR47adz4DPafw+g@mail.gmail.com>
Subject: Re: [PATCH 4.14] inet: use bigger hash table for IP ID generation
 (backported to 4.14)
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Eric Dumazet <edumazet@google.com>, Willy Tarreau <w@1wt.eu>,
        "David S . Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

I believe you ask about this one:
[ Upstream commit aa6dd211e4b1dde9d5dc25d699d35f789ae7eeba ]


On Fri, Jun 18, 2021 at 1:24 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Jun 18, 2021 at 02:51:22AM -0700, Amit Klein wrote:
> > Subject: inet: use bigger hash table for IP ID generation (backported to 4.14)
> > From: Amit Klein <aksecurity@gmail.com>
> >
> > This is a backport to 4.14 of the following patch, originally
> > developed by Eric Dumazet.
> >
> > In commit 73f156a6e8c1 ("inetpeer: get rid of ip_id_count")
> > I used a very small hash table that could be abused
> > by patient attackers to reveal sensitive information.
> >
> > Switch to a dynamic sizing, depending on RAM size.
> >
> > Typical big hosts will now use 128x more storage (2 MB)
> > to get a similar increase in security and reduction
> > of hash collisions.
> >
> > As a bonus, use of alloc_large_system_hash() spreads
> > allocated memory among all NUMA nodes.
> >
> > Fixes: 73f156a6e8c1 ("inetpeer: get rid of ip_id_count")
> > Reported-by: Amit Klein <aksecurity@gmail.com>
> > Cc: stable@vger.kernel.org
> > Cc: Eric Dumazet <edumazet@google.com>
> > Cc: Willy Tarreau <w@1wt.eu>
> > ---
>
> What is the git commit id of this patch in Linus's tree?
>
> thanks,
>
> greg k-h