Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1364744pxj; Fri, 18 Jun 2021 05:43:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwi+cSKc4cNk7Y/1PGmi6P6YlZHqCc04PFTn6WFQWderAgFJeTzS/FVChbqc/KlQZwmZEX4 X-Received: by 2002:aa7:d801:: with SMTP id v1mr4686215edq.349.1624020214979; Fri, 18 Jun 2021 05:43:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624020214; cv=none; d=google.com; s=arc-20160816; b=lhZ8baTvOCVNo1WZr693aRlOdoZxmqI/dV5za4E7bruyRVEpZE7IBlRXRGdHO/RCOh bx2KzpSDNbJ56Fy8l7mAt8FBpW4eeO2QnbL51P69ZZARTT4+DsWH7UrOq9VljCorAP5h bNwxMLiEdOzn+qsadGUNCdRvY00jhgUenH/V6tKx7eBsHpSd8QBivYu4V4AbUH4oCN51 OUDHElURKbPlCfJCpUiu6P/CJgn/42bXp4I+GrfpSWCeb36VOADg9Jo3hwMnw9K9sTn0 DHid6w3RLDoNS8X3FCUnxfomVH+Blt1Gpvc92yR/dcfN55+lw/pa414pxCQqx0BxLUxb wdcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=UWOiNUsiskqs16bHt1+xyUpwGOm94x7PrzWxU4et8KM=; b=uTDCUudka+k2yGU72soHEJuQPwxNZkfktedstCP96TMudrLgSu/VN/mI7UqGRudl1M jvIpedHzGo1YA7/J1LqJwnQWIbeU4KvNZHIXsKDGBG15WZPDlwOnc0xmzVtfD4Y7bRfW msFGH4Fk7G2q0MQW7Scxx0ObsNf+6k/r0sgp27Ocbfqju+cpQ5x5yUonigIkdgwC4qHB bwY5F4J7hT2D8PtTtMPbnYjpD12wU0jnsSuEpVfiODVWuIGcGqOHeOPzksuw50vZD+eL mhkjHIlrLbluTxC4r+zJEcmvnbdEVV5fk0BnfCj8tllAIuMRqsbF9bAvj5SSG9abKaVg xljw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SqlXqi54; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y13si2313763ejk.111.2021.06.18.05.43.11; Fri, 18 Jun 2021 05:43:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SqlXqi54; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233050AbhFRLfx (ORCPT + 99 others); Fri, 18 Jun 2021 07:35:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:51038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231247AbhFRLfx (ORCPT ); Fri, 18 Jun 2021 07:35:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7E68B610CA; Fri, 18 Jun 2021 11:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624016024; bh=9s2RQDW9wanQqORyAIBE9pVzVvO91REtRxxPhTclx3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SqlXqi54Wb+yJCY85fbszND337jMrH1YM9XsF+vWgllGBpqb9VlxWeoQIneYKtmoL DDWw6wt7vpYW0ktptOHD07s18Z7MKMyqxG+QttWQ+0Vs2sUxhpzUOOPOfsT/wModgb KXCsOEO7f9llPwPii+Ae6A6fRw2dlavWsuGTs3GxHsarnYKzEzSFsGSjK7tZq9E9nB aijS9ai4jkTUI2U2HTPCWoqjIGzZ2KpEeJPAT0iO0F5xtCjm/IyRptmvk+3pMiwIFR zzUZ93Gzt1DsGgsmiJO5sWtcXSjvGbPlxA3dkXDbdCcC6ctVmJhpGelXftHm9jGPSx NZ7ixSeKGTPsg== Date: Fri, 18 Jun 2021 12:33:22 +0100 From: Mark Brown To: Shengjiu Wang Cc: Fabio Estevam , Shengjiu Wang , Linux-ALSA , Timur Tabi , Xiubo Li , linux-kernel , Takashi Iwai , Nicolin Chen , linuxppc-dev Subject: Re: [PATCH] ASoC: fsl_xcvr: disable all interrupts when suspend happens Message-ID: <20210618113322.GA4920@sirena.org.uk> References: <1624009876-3076-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9amGYk9869ThD9tj" Content-Disposition: inline In-Reply-To: X-Cookie: Are you a turtle? User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9amGYk9869ThD9tj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 18, 2021 at 07:30:25PM +0800, Shengjiu Wang wrote: > On Fri, Jun 18, 2021 at 7:21 PM Fabio Estevam wrote: > > The operations in _suspend() are usually balanced with the ones in _resume(). > > Shouldn't you enable the interrupts in resume() then? > No, as you said below, the interrupts are enabled in fsl_xcvr_prepare(). > so this change should not block anything. Might be worth a comment explaining why there's the asymmetry. --9amGYk9869ThD9tj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDMhIIACgkQJNaLcl1U h9APMQf/d/lJMjdPrNhdzJeuS3tVHQ268JZCwmabDferZbnDRbjuwaiq+4wAdnBC EFksPtmaTNBBrrLUc1bTxLs0Hl0wBGNv+zf5r8FCfEm60zrQF3QKDTZ1t46ZelbX 9uQRMcFanYwBChVofttzEwDHWStsDCHoi7pfP4ZwGTR+SR6rERyzgAv43862ne/G klbzzYKa+CyLGvojCzNTZBvkyNPQCkhuazh7wk6UolcFTf2oz+wjUPYyJ/Xbwqb5 t+Y4zwAqMls5GZtzFWIohvRgCULmADRq8FqCzFQIYm3teLhDgQGtbM8Xn2Tz3Vp0 MQveAgdluQ8hDsBYMq31CB4CgMOZag== =a0cm -----END PGP SIGNATURE----- --9amGYk9869ThD9tj--