Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1370474pxj; Fri, 18 Jun 2021 05:51:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCLP9g1/uKVJ5++r0WfwigfqlfHMNbmHO3jFbn/GPNyku9CMSawOg8B6PXwx8EUGW/93V/ X-Received: by 2002:a17:907:3d8e:: with SMTP id he14mr11156674ejc.178.1624020707276; Fri, 18 Jun 2021 05:51:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624020707; cv=none; d=google.com; s=arc-20160816; b=uoHp1J+s0O++lgL4oeTAI5zWaavjwA3nEKAD0bwbL+Utx1nFHEEMivgS8sMNHOh8dt aZYc9FXUyGREBIV+sueGp2yDfxTcfFtxWX9oznd/mwFdMw80/gE/q1QBUlWEeT7pC4wy j19qjMzSj/R79Wn5huo0ANPDGRVfGo09l4QYO7vuA/SYBnX02IdhUdzF0GRVnq7hdXfP JTAGYHeiH/9kxLOmE2D102PGD78OfR62VKSEYaIdyTEhk+EGO4KkfoZPGACwHrGkhYpH CAhY3slZ8dC/i2edJkuy+7NDGNMO8cCnE6zfFCpWT/KTaYeHrYlT+C2tVt7XA2OkMXxR xCrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DJD/MySWnPvXQuwIf3J/ioBbrWLOimWmN1G5D/biUJc=; b=wwSCfvDRagvAoEkbxuUJSoxOBWTSjQIU0IUa8OSmDWFUah8cDOJ4mwZNqSMa4/W173 Jx7YGm4e81gGS+sJg5AZqh8zctqghz3BR9E7uSEqg01U3BxQt6XtOWadrxmxv2Sks30P YFsi4EQ+4n+S/hNpzqXqb+GjTy/op1eFbjGbVikNMJHWKW2LOC+kUKCx2BS3FWIayvW9 5b/Xwm+NzmS7gtEAQK5DNjZ6WqTj0N12OhqCLQilhakTEY6c5uXyQ3BNANjIe14BChuj a+m/17to8iFanqJLk6F1BWJEa6w1hQbrI64KKQ9akO7dJUDyPlzlu+p+n7zs25CipDm4 A9Sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=aa60WENu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 16si2201771ejf.233.2021.06.18.05.51.24; Fri, 18 Jun 2021 05:51:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=aa60WENu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232882AbhFRMG6 (ORCPT + 99 others); Fri, 18 Jun 2021 08:06:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231193AbhFRMG4 (ORCPT ); Fri, 18 Jun 2021 08:06:56 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1824CC06175F for ; Fri, 18 Jun 2021 05:04:47 -0700 (PDT) Received: from mwalle01.kontron.local (unknown [213.135.10.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 3A9A12225B; Fri, 18 Jun 2021 14:04:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1624017885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DJD/MySWnPvXQuwIf3J/ioBbrWLOimWmN1G5D/biUJc=; b=aa60WENuM6qJuScG3Nv4FJ/JuBjXhFbNZYeL5p8Qy7CMFuzBm/jSLxh9G6T3T5qdfEMIjQ O0uVn3acXedToDZenD4R6g+SUegJEQzPnbiSTyiFhiFltmZU+nfJQW6rJcyQCQNVbcebaC Ybf3ztjWn489PgxE1IAIKPq/hyu/g6Q= From: Michael Walle To: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter , "Lukas F . Hartmann" , Michael Walle Subject: [PATCH 2/2] drm/etnaviv: add clock gating workaround for GC7000 r6202 Date: Fri, 18 Jun 2021 14:04:33 +0200 Message-Id: <20210618120433.14746-3-michael@walle.cc> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210618120433.14746-1-michael@walle.cc> References: <20210618120433.14746-1-michael@walle.cc> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The LS1028A SoC errata sheet mentions A-050121 "GPU hangs if clock gating for Rasterizer, Setup Engine and Texture Engine are enabled". The workaround is to disable the corresponding clock gatings. Signed-off-by: Michael Walle --- changes since RFC: - corrected the wording of the comment drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index 4102bcea3341..c297fffe06eb 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c @@ -613,6 +613,12 @@ static void etnaviv_gpu_enable_mlcg(struct etnaviv_gpu *gpu) etnaviv_is_model_rev(gpu, GC2000, 0x5108)) pmc |= VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_TX; + /* Disable SE, RA and TX clock gating on affected core revisions. */ + if (etnaviv_is_model_rev(gpu, GC7000, 0x6202)) + pmc |= VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_SE | + VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_RA | + VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_TX; + pmc |= VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_RA_HZ; pmc |= VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_RA_EZ; -- 2.20.1