Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1373636pxj; Fri, 18 Jun 2021 05:56:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVu3JBZJnXQOw+NODCHlZgYydhdJ7ABZR6HL6FWZZ3KK7ifNDioS+kT146qEsTxM4Nt1jS X-Received: by 2002:a02:335c:: with SMTP id k28mr3193750jak.4.1624021014855; Fri, 18 Jun 2021 05:56:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624021014; cv=none; d=google.com; s=arc-20160816; b=sFjaQSsFlrwB4O9U91JIe68/Om26LF8wwRNxdwP7/TqNJ3UK+6uc6QDerC6sofyJrq zw/EeJkvQPuFD884o4ChujtGs9KB8TmbIihA5wEQq0RCUXDLg3HUyhHJPypGMvYeeF8d DGOipo3Xnuyy9607jKgnnkIre46nGq2oRjjpL39GMe4dhtIyJJ0vOJnWe8ZIyOKivb33 GyjRh7qW7L367atFT+UK25QsMeNL79CN40VS+w/XntZuB47fl+2LG0FqP02XM/WPfJBG wu0r1Kl0y1utQDfibFXtSYhfY4Cz0bra7GD1FZAxpKxgqZ0SRzCv9uoT0Ah660nGzlCL jmhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=osMXZB6zVUCRxwMKbtanTuzmkF8QH55sKJbs0+x3AmY=; b=UTHQpMAOelGgD3t7gN2KIl2Zw5A6gn8+pToMQLVuFDXybrR1nQTk6M42mwFYBZSSdn om3sri8yKT/7uQddT2LBkosXgzSfSzQ5pasT2hBybTxhih7R59JMHXA5UsZ3JmwEyN4f nCB8OcInJOCSfMuAbFjlVV9NMnIT+OAQzxJO0HNr1D/iuMt1c5Mmvdn1DJ/rLNiM+UcW kBY6yLf/v3jIpHFht38yIDnPKc2sq4C2lB1iBmdB6n4MNjEE7tNiQVAmbDiVe9YSmoPX iGso8pEso68iTSxcqlaK3itWZWk8S+Ybkc4i2PwoUjqMhNZ5a+Njul5+IQxc0RzNflMC NxfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fVsM4046; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 141si10138178iou.9.2021.06.18.05.56.42; Fri, 18 Jun 2021 05:56:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fVsM4046; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234458AbhFRMca (ORCPT + 99 others); Fri, 18 Jun 2021 08:32:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234352AbhFRMbu (ORCPT ); Fri, 18 Jun 2021 08:31:50 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4C63C0611C0 for ; Fri, 18 Jun 2021 05:29:34 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id s15so8365021edt.13 for ; Fri, 18 Jun 2021 05:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=osMXZB6zVUCRxwMKbtanTuzmkF8QH55sKJbs0+x3AmY=; b=fVsM4046HINJ+QXPvD+ppPBaulEvl1ZxQ1MH8dRFpJhgXjGHguP7eGr0SgfcKYh6yH qIy2w8HjMHa9OCz5oyskCTQub2iP+V+NFuVDD7ZzbzbXqEBPFvgy9egJo39iARxC5Qhc 1vFXSaypcnh7dCd5NTYkaj5yqd70jrRQLAdlc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=osMXZB6zVUCRxwMKbtanTuzmkF8QH55sKJbs0+x3AmY=; b=kkliibKxwq90ZzpzQP9g5pkuF+ikBr39zGd94PNTopbfXZcARvgVwLrQKRqfBryQro XZAEZ14RFltMioWX1CBBex80yFsFLlsSWNBIwCsvVe0E0TLzv6J5ETkKRcdVWx7sGy62 ym2P/nWZU6kmwwfJvyn+axVIqxREuU8pwVM1DcaBDAptlIUO7Kz/ok84UB1nRoRdp04A 4q7tUtHgHa57dRWi9u1cVQ56NcFtVIr0rvUghCL2VQNF5ZTqWNH0P7NLuwuxwlAyhXVF axeWW9mfw05JXuygyVdTyKz6PVXroZP76KEQImxsxJjPu1jScs+PCqzresmt24yf3TeV V93w== X-Gm-Message-State: AOAM531cB3MZC3LR9l1iLecmwFxqoLB7U5gVPeRyhr9y8a1KL2YjWn7d Hcs7sHrIUPtfji9vhUtncIGmlg== X-Received: by 2002:aa7:cdd9:: with SMTP id h25mr4692295edw.246.1624019373590; Fri, 18 Jun 2021 05:29:33 -0700 (PDT) Received: from alco.lan (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id o26sm4336403edt.62.2021.06.18.05.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 05:29:33 -0700 (PDT) From: Ricardo Ribalda To: Laurent Pinchart , Hans Verkuil , Mauro Carvalho Chehab , Sergey Senozhatsky , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, tfiga@chromium.org Cc: Ricardo Ribalda Subject: [PATCH v10 12/21] media: uvcvideo: Increase the size of UVC_METADATA_BUF_SIZE Date: Fri, 18 Jun 2021 14:29:14 +0200 Message-Id: <20210618122923.385938-13-ribalda@chromium.org> X-Mailer: git-send-email 2.32.0.288.g62a8d224e6-goog In-Reply-To: <20210618122923.385938-1-ribalda@chromium.org> References: <20210618122923.385938-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hans has discovered that in his test device, for the H264 format bytesused goes up to about 570, for YUYV it will actually go up to a bit over 5000 bytes, and for MJPG up to about 2706 bytes. We should also, according to V4L2_META_FMT_UVC docs, drop headers when the buffer is full. Credit-to: Hans Verkuil Reviewed-by: Hans Verkuil Reviewed-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvcvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h index 5eb7e87f8430..37a092d717cf 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -524,7 +524,7 @@ struct uvc_stats_stream { unsigned int max_sof; /* Maximum STC.SOF value */ }; -#define UVC_METADATA_BUF_SIZE 1024 +#define UVC_METADATA_BUF_SIZE 10240 /** * struct uvc_copy_op: Context structure to schedule asynchronous memcpy -- 2.32.0.288.g62a8d224e6-goog