Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210522211055.15988-1-mirela.rabulea@oss.nxp.com>
 <20210522211055.15988-3-mirela.rabulea@oss.nxp.com> <DB9PR04MB8477D8F7DC86E67F74D5D9F780269@DB9PR04MB8477.eurprd04.prod.outlook.com>
 <e4c174afd7c55c56c68afbe69276b41c3f574964.camel@nxp.com> <CAA+hA=TEi3iZ+nOfff=aN1FrLGb6+OHfx23aWaa1J7YfZRRgtA@mail.gmail.com>
 <15d5728aeb7895f81f833e7f7e281861c1fcef9a.camel@collabora.com>
In-Reply-To: <15d5728aeb7895f81f833e7f7e281861c1fcef9a.camel@collabora.com>
From:   Dong Aisheng <dongas86@gmail.com>
Date:   Fri, 18 Jun 2021 20:47:57 +0800
Message-ID: <CAA+hA=RB_va3TRhjFBSofVqDEpj_LxLfUM84ead5D2LLZ3KRwA@mail.gmail.com>
Subject: Re: [PATCH v13 2/2] arm64: dts: imx: Add jpeg encoder/decoder nodes
To:     Ezequiel Garcia <ezequiel@collabora.com>
Cc:     Mirela Rabulea <mirela.rabulea@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "G.n. Zhou" <guoniu.zhou@nxp.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Laurentiu Palcu <laurentiu.palcu@nxp.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "paul.kocialkowski@bootlin.com" <paul.kocialkowski@bootlin.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Robert Chiras <robert.chiras@nxp.com>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        Peng Fan <peng.fan@nxp.com>,
        "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jun 11, 2021 at 11:01 PM Ezequiel Garcia <ezequiel@collabora.com> wrote:
>
> On Fri, 2021-06-11 at 21:33 +0800, Dong Aisheng wrote:
> > [...]
> >
> > > > > +img_subsys: bus@58000000 {
> > > > > +   compatible = "simple-bus";
> > > > > +   #address-cells = <1>;
> > > > > +   #size-cells = <1>;
> > > > > +   ranges = <0x58000000 0x0 0x58000000 0x1000000>;
> > > > > +
> > > > > +   img_ipg_clk: clock-img-ipg {
> > > > > +           compatible = "fixed-clock";
> > > > > +           #clock-cells = <0>;
> > > > > +           clock-frequency = <200000000>;
> > > > > +           clock-output-names = "img_ipg_clk";
> > > > > +   };
> > > > > +
> > > > > +   jpegdec: jpegdec@58400000 {
> > > >
> > > > Node should be disabled by default.
> > > > And enable it in board dts including LPCG.
> > >
> > > At version v5 of this patch, the node was disabled by default, and I
> > > received this feedback from Ezequiel Garcia:
> > >
> > > "Pure memory-to-memory are typically not enabled per-board, but just
> > > per-platform.
> > > So you can drop the disabled status here."
> > >
> > > So, in v6 I made it enabled by default.
> > >
> > > Any strong reasons for enabled/disabled per platform?
> >
> > AFAIK we usually only enable system basic features and let other
> > user selectable features disabled by default in dts.
> > Even for device LPCG clocks, if it's enabled by default and later
> > enter runtime suspend if no users, it still consumes power.
> >
>
> Well-written drivers shouldn't draw any power if not used.
>

LPCG won't draw power when not used. But the power domain used by LPCG
will still draw power when enter idle state.

> And DT is about hardware-description, not about usage-description.
> Which means, at the soc.dtsi level you disable devices that need
> some board-level hardware thing to be enabled (e.g. a physical
> connected, a regulator, etc.).
> A pure memory-to-memory should be enabled by default, because
> in practice you can't predict what the users a board will want
> to use, nor the DT is the place for that.

It makes sense to me. Thanks

Mirela,
Please follow up with Ezequiel's suggestion.
For LPCGS used by jpeg, you can keep it enabled by default.

Regards
Aisheng

>
> Sticking to hardware description is the best way to get DT right :-)
>
> Cheers,
> Ezequiel
>