Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1458813pxj; Fri, 18 Jun 2021 07:35:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQvwr1hC1E441hE6/DMkPLisxVDh0p+4TWFOpuKr2GCNFzXH4Ju7u3lpcukQdjctsNEH22 X-Received: by 2002:a92:ce41:: with SMTP id a1mr4763277ilr.283.1624026906252; Fri, 18 Jun 2021 07:35:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624026906; cv=none; d=google.com; s=arc-20160816; b=A4Jd5uWlIV+eXmUVwkuPyj9bW+xabW6eWBsa+hDr9/RmuHyY2GAMZDAyrGYPewQFoR e3dgSTowM5qsCKGgMyaguq4bGIOoBnj3XNPNgMg7WeAqUcpBNY1myW9oKuvirKrk4sfD WE9YJV+7SCIqAhMiNsFme+hIJA3ujkc3GB88BbcwReWNOXj8dVwUQlzRsLj8L3Alz9eK sIKUy5gqQwMLkycSSfeoYKzIup86+clkR+LsI72FLQBFHCVUjK7SgN1O53cG/J6TiVQ9 wSOehvDpeLHanWxbI5KJ3l2KlKsraDd291zVrCSTNVnbEgmDVtS4fiaZZ8jX0boTNQxo Ifuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=MK/uUJqL6Bn66BNVr2wA5MZ+EL7chR3X7ferQ1ZwG3o=; b=zcHMEup1s/I1llIfLxyVN9nyTPDQdX2R4faGhI+RZKUiWfdrQVVBYYH2xcPiZJk5Xg 6e+6/sMuictl/f13o8UI9o5UvNNhHQ/Bi75bXA3/E4Ck2JYkBjE24I8LG7S8Cqc2HvZp P346LIqh4cWkZ2DjXkc3IowiRtD/IWCEhU7DP69W37Oe44lY9PSwUqiOVTzAGLTYqYuf 15eFdIYlgjxKyk48yRg94NhoMwAKJMXGAgyac9PyQkT/sOHqO+WLEoAQKWl0Erg99PJM 9l85l1gX55o/F8AeWvHDX5KMOYBkbDpLV0jDg3w7Cvvnb1StAoUz+dGPUTXcDoOfZAJ4 wncA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si2286346ilq.122.2021.06.18.07.34.53; Fri, 18 Jun 2021 07:35:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234570AbhFROe3 (ORCPT + 99 others); Fri, 18 Jun 2021 10:34:29 -0400 Received: from verein.lst.de ([213.95.11.211]:35190 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233642AbhFROe1 (ORCPT ); Fri, 18 Jun 2021 10:34:27 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 64B2C68D08; Fri, 18 Jun 2021 16:32:12 +0200 (CEST) Date: Fri, 18 Jun 2021 16:32:12 +0200 From: Christoph Hellwig To: Tom Lendacky Cc: Claire Chang , Stefano Stabellini , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Will Deacon , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com Subject: Re: [PATCH v13 01/12] swiotlb: Refactor swiotlb init functions Message-ID: <20210618143212.GA19284@lst.de> References: <20210617062635.1660944-1-tientzu@chromium.org> <20210617062635.1660944-2-tientzu@chromium.org> <741a34cc-547c-984d-8af4-2f309880acfa@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <741a34cc-547c-984d-8af4-2f309880acfa@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 18, 2021 at 09:09:17AM -0500, Tom Lendacky wrote: > > swiotlb_init_with_tbl uses memblock_alloc to allocate the io_tlb_mem > > and memblock_alloc[1] will do memset in memblock_alloc_try_nid[2], so > > swiotlb_init_with_tbl is also good. > > I'm happy to add the memset in swiotlb_init_io_tlb_mem if you think > > it's clearer and safer. > > On x86, if the memset is done before set_memory_decrypted() and memory > encryption is active, then the memory will look like ciphertext afterwards > and not be zeroes. If zeroed memory is required, then a memset must be > done after the set_memory_decrypted() calls. Which should be fine - we don't care that the memory is cleared to 0, just that it doesn't leak other data. Maybe a comment would be useful, though,