Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Adam Manzanares <a.manzanares@samsung.com>
To:     Niklas Cassel <Niklas.Cassel@wdc.com>
CC:     Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        Shaun Tancheff <shaun@tancheff.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Jens Axboe <axboe@fb.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] blk-zoned: allow BLKREPORTZONE without
 CAP_SYS_ADMIN
Thread-Topic: [PATCH v3 2/2] blk-zoned: allow BLKREPORTZONE without
        CAP_SYS_ADMIN
Thread-Index: AQHXYRgQCVfFQ7HNWEWEcKzi48L9sqsaVZAA
Date:   Fri, 18 Jun 2021 14:49:56 +0000
Message-ID: <20210618144956.GB33886@bgt-140510-bm01>
In-Reply-To: <20210614122303.154378-3-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B5CDFD0C97F7DA4584EDD78FCE32D6C1@ssi.samsung.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
CMS-TYPE: 301P
References: <20210614122303.154378-1-Niklas.Cassel@wdc.com>
        <CGME20210614122358uscas1p1b06438713a13aef1eb31a9b0a6c359dc@uscas1p1.samsung.com>
        <20210614122303.154378-3-Niklas.Cassel@wdc.com>
Precedence: bulk

On Mon, Jun 14, 2021 at 12:23:21PM +0000, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@wdc.com>
>=20
> A user space process should not need the CAP_SYS_ADMIN capability set
> in order to perform a BLKREPORTZONE ioctl.
>=20
> Getting the zone report is required in order to get the write pointer.
> Neither read() nor write() requires CAP_SYS_ADMIN, so it is reasonable
> that a user space process that can read/write from/to the device, also
> can get the write pointer. (Since e.g. writes have to be at the write
> pointer.)
>=20
> Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> Cc: stable@vger.kernel.org # v4.10+
> ---
> Changes since v2:
> -Drop the FMODE_READ check. Right now it is possible to open() the device=
 with
> O_WRONLY and get the zone report from that fd. Therefore adding a FMODE_R=
EAD
> check on BLKREPORTZONE would break existing applications. Instead, just r=
emove
> the existing CAP_SYS_ADMIN check.
>=20
>  block/blk-zoned.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index 0789e6e9f7db..457eceabed2e 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -288,9 +288,6 @@ int blkdev_report_zones_ioctl(struct block_device *bd=
ev, fmode_t mode,
>  	if (!blk_queue_is_zoned(q))
>  		return -ENOTTY;
> =20
> -	if (!capable(CAP_SYS_ADMIN))
> -		return -EACCES;
> -
>  	if (copy_from_user(&rep, argp, sizeof(struct blk_zone_report)))
>  		return -EFAULT;
> =20
> --=20
> 2.31.1

LGTM

Reviewed-by: Adam Manzanares <a.manzanares@samsung.com>=