Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1533023pxj; Fri, 18 Jun 2021 09:07:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfhfDzBG0FZa+Y1u21cyFqp2VKxxZWZWz2Bxr/tO9p9dkVwO8LGAM73yCccNCKrCibiaHV X-Received: by 2002:a17:906:d1d5:: with SMTP id bs21mr12032961ejb.378.1624032470404; Fri, 18 Jun 2021 09:07:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624032470; cv=none; d=google.com; s=arc-20160816; b=xKwkvTKcjUJWf810wvcXw9mTjSNv1gZtzogKAULGzizSJZ8HZztBt2eVxBvlnpv4qM GwgLELHNYMoATUXaS/XIJvqRl4fvOmOuueGAYohdIBKRhAGq1YLIm+u6ajoUx9rk841j PwHlWetoQQCVrvcubCqtL+yt0LPKvRTB0etusFUXXrDqPhCcHxXm59mY8i40ipc/SY5w Ga202SHflBE686Q/BnFUBZiysYAtb6Vc5A9tTnCR3ARcIthEz2fdqPoZjwSBvGhlxUa5 VF3SIanFqNBpt9u6WfLgaRpw9iWrj6kIb7A4OuTwSiH2R9klvfSdiSsCilPFup/CNyB0 dKig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=m7cv6XMGc0QYQ0f7LcJq3MCNNmoHJMl8V7pDRZtvXzY=; b=xxSzouCL6h6bzFPKdEFdMPwRm32RPhTM5sXYigGQ6uwMhASA1uMVKTdJU18ZeSaAKB uc4HXPWB0SxX/S/QqMDbMb5I64np7XRFt+CCDZNzsBJ0ULE1nF7lNZ3qngmebJUbTN0L U1ZlMCCg6Mh32T8+/rLmp1MhiNhVuhUkCE5PhWAi2+AeJcr2zKF6pCLiqDY7mNLmoo8/ +c4GFsN8XBHPq/fIlu/m9UP0rCk0OBEQLCoD+cOnESLTh5yIaBlOkVfdCpQ4a1lK0Y53 h0T1nqUAgzj0CqOQ7KYu17fCwcI7P9PZ4W1u/RxNS5WJNApxxDbFUUg1xbrAnEEfKT1U s0bg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d4si857092ejl.538.2021.06.18.09.07.26; Fri, 18 Jun 2021 09:07:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232793AbhFRM5V (ORCPT + 99 others); Fri, 18 Jun 2021 08:57:21 -0400 Received: from mga17.intel.com ([192.55.52.151]:24557 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232837AbhFRM5K (ORCPT ); Fri, 18 Jun 2021 08:57:10 -0400 IronPort-SDR: I4ZcWTpUu+d7bpPLWM0jIvIfJEeaO4dM41WIq02LNrMJdtHhEatNtEyRYxzVON7JF+E3aQvwKm O+Re5ItW6E0w== X-IronPort-AV: E=McAfee;i="6200,9189,10018"; a="186926061" X-IronPort-AV: E=Sophos;i="5.83,283,1616482800"; d="scan'208";a="186926061" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2021 05:54:59 -0700 IronPort-SDR: 1kbTWI+eR+KE5WgtuOOUpYKOuuU/aXLhV+DMkydjWPCfI4vWa6ynSbn9hwXXvY1ERPB/EAG4p9 QhmoUEBZ14Yg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,283,1616482800"; d="scan'208";a="640700723" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 18 Jun 2021 05:54:56 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 826B9431; Fri, 18 Jun 2021 15:55:21 +0300 (EEST) From: Andy Shevchenko To: Hans de Goede , Mario Limonciello , Andy Shevchenko , Daniel Scally , Heikki Krogerus , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Mark Gross Subject: [PATCH v2 2/8] platform/x86: intel_skl_int3472: Free ACPI device resources after use Date: Fri, 18 Jun 2021 15:55:10 +0300 Message-Id: <20210618125516.53510-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210618125516.53510-1-andriy.shevchenko@linux.intel.com> References: <20210618125516.53510-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We may free ACPI device resources immediately after use. Refactor skl_int3472_parse_crs() accordingly. Signed-off-by: Andy Shevchenko --- v2: new patch .../x86/intel-int3472/intel_skl_int3472_discrete.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c b/drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c index 8c18dbff1c43..48a00a1f4fb6 100644 --- a/drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c +++ b/drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c @@ -308,8 +308,10 @@ static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472) ret = acpi_dev_get_resources(int3472->adev, &resource_list, skl_int3472_handle_gpio_resources, int3472); - if (ret) - goto out_free_res_list; + if (ret < 0) + return ret; + + acpi_dev_free_resource_list(&resource_list); /* * If we find no clock enable GPIO pin then the privacy LED won't work. @@ -319,7 +321,7 @@ static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472) if (int3472->clock.ena_gpio) { ret = skl_int3472_register_clock(int3472); if (ret) - goto out_free_res_list; + return ret; } else { if (int3472->clock.led_gpio) dev_warn(int3472->dev, @@ -329,10 +331,7 @@ static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472) int3472->gpios.dev_id = int3472->sensor_name; gpiod_add_lookup_table(&int3472->gpios); -out_free_res_list: - acpi_dev_free_resource_list(&resource_list); - - return ret; + return 0; } int skl_int3472_discrete_probe(struct platform_device *pdev) -- 2.30.2