Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1641891pxj; Fri, 18 Jun 2021 11:29:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHsTIesc9Q+Op9rGn7Pl6BQoOqQlFR4sMGBSdr121wZaqbdyzIgWl21+thQlTH8YHZvCQT X-Received: by 2002:a05:6602:334e:: with SMTP id c14mr3766216ioz.78.1624040994313; Fri, 18 Jun 2021 11:29:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624040994; cv=none; d=google.com; s=arc-20160816; b=JlP7sUa2zAgquM56ckMNiuFOtUtG0BjcEhJr2Qx3s3ZtOYZs7F+3RqEiFm+OdKkkWs utXuXcoEZsiZ77dF0ytUyvGbNHBqYMgrHofyAXfXoUZLBXeEZQtNyYUPukKGlXaIucKA o3X8CXArXobQOfrLes2QXI+62nUpG3AieQb+LkBSzmWQTzE42LwVl10ej4DiGr1pJYzR DaMNwDdrTTnFSdcr7ppxcqkdw2EAcvwSlmdG7ArQ4w0hChBbAkYCsBEmAcql9kzoyiJu i5fXyOzrABpM+yF0RaisN06S6ykWqoZCRvnNlK1tLwWtbiWgWzs9NJupV8VY70nYJlSy h/3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=TB7pwWfxR24AkksoNcBZCIOfoPStwv2Y7YdgADB8mv0=; b=khrTMCY+pT1/OjetMQdZd/lPdSRc+Vwea77kCAwmmxFx21crz+p3aESP7p3SCjbE2K r6K0rmCGSsWhwR8QRh7xD8TvD/0E1mt5eyp7zxQwfMxFyXFSCfGO/UmGAEuEk6yTRn9P L5V9b8+YHEaV82H8GkHFejPF1+LNAibFykLb0a1lIZO5d+x1PoNHV4VdAFAI50OgjPXO eJLY+fhcRLGbOuXpgOr69wx8l9EyuXHK6iBMCBZjSLxDVDhmBRmzuQV6NXdTGBD5BkD5 INWaX1YVivBmH8LCZfvo1PnjDAKYoZV2ZSVj+/56mzEsXmM1fWfReMh4CzENj27czWx8 jNsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b9si2446731ilq.92.2021.06.18.11.29.42; Fri, 18 Jun 2021 11:29:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235584AbhFRPnj (ORCPT + 99 others); Fri, 18 Jun 2021 11:43:39 -0400 Received: from mga01.intel.com ([192.55.52.88]:8805 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230334AbhFRPni (ORCPT ); Fri, 18 Jun 2021 11:43:38 -0400 IronPort-SDR: 8AzzueQucBj/AynsG4tI3u5SvnYScx1uhJf3eT9jecCG/RuuUL1aphk9eNveVqzr9I12mOBgUJ 8KtkXBj/aRMw== X-IronPort-AV: E=McAfee;i="6200,9189,10019"; a="228101784" X-IronPort-AV: E=Sophos;i="5.83,284,1616482800"; d="scan'208";a="228101784" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2021 08:41:24 -0700 IronPort-SDR: gq5tTQh+yktvAOnoe+4Fx5WopWiz9CMdXC/dPgOfFxCHFNrVaurn0BPvcDgK5m9R/G2ZSb9hmp bTRDjo0V/tAw== X-IronPort-AV: E=Sophos;i="5.83,284,1616482800"; d="scan'208";a="451431532" Received: from mahmoo2x-mobl.amr.corp.intel.com (HELO [10.252.143.210]) ([10.252.143.210]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2021 08:41:23 -0700 Subject: Re: [PATCH] x86/sgx: Suppress WARN on inability to sanitize EPC if ksgxd is stopped To: Borislav Petkov , Sean Christopherson Cc: Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Dave Hansen , "H. Peter Anvin" , linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, Du Cheng References: <20210616004458.2192889-1-seanjc@google.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <3b7b7c4e-968b-530e-90f7-e13470f8b116@intel.com> Date: Fri, 18 Jun 2021 08:41:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/17/21 9:45 AM, Borislav Petkov wrote: > Hmm, this looks weird. Why aren't we starting ksgxd only after > *everything* has initialized successfully? I.e., after both kvm and > native drivers' init functions have succeeded? ksgxd has two roles. I think that's why it looks weird. The obvious role is its use as the kswapd equivalent for SGX. But, it's also used to speed up SGX initialization. It "sanitizes" the EPC asynchronously because it can take quite a while. That's why it gets launched off early. If it gets interrupted, that's when this warning can trigger. I think you're suggesting that we just defer starting ksgxd until we *know* it won't be interrupted, basically moving sgx_page_reclaimer_init() down below sgx_drv_init() and sgx_vepc_init(). While I can see why it's best to get it going as early as possible, I don't see much going on in those init functions that would justify needing to fork off ksgx earlier. Am I missing anything?