Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1693505pxj; Fri, 18 Jun 2021 12:51:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCCTrxxOXAcz56f1MVwY0jyzu/MKxzvmx9qr+yD7okQMlR5mZERdL3Jl+3d07Yz81kiykU X-Received: by 2002:a17:906:f188:: with SMTP id gs8mr4246163ejb.527.1624045887519; Fri, 18 Jun 2021 12:51:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624045887; cv=none; d=google.com; s=arc-20160816; b=AeleZxKWG/72QFDOnS/nFPS4BCbbfwJrT+Bywb8fA5lgb5IHcRLIpQG1cJSTh3Iq8A 9b1pT6LaPWIdgNgCs2fWREwaUwL0dR2LmQLdcM9+POfYsLTvnYICMATPR+dJzuB59muS efeFTezLOTXP7kUDKUqz0fyboSDOWyuJxTdYM4kSarkl0tNdAbBvM1yGfxwKQ0bGKu1H avz5j9PqIJ/uv4Dpqzdc+ln0cqjAyEr7qvwmskYGdU+bcEZHp8bb9yZjdPRl2NXnSG1l mgHPM9GV2PCTm8hv7/GbbTvKvrvRAKdL3CWrVL4q6kupb+1fqKps1K1cpuTkLfDJp1mL +A0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=yLhjuHWbELjLdC44C/8FSqq5JzwR773aqAh+gTIM3/0=; b=S3JQwpXxtueN+806mD43111u2k8+wuO9F8rVmB0F9j9lPyHVcud4eUYqexwe/BW1Pl R+82cXbkgcIaqBEwG7Bx7ZvosqvUQho734Dh1cFUqJh4KI0UoEPf+hzJ3gtVTnHXvw1i ckuT77uX3xLqigNU9Epud27DYba+f/LhaC1p7PAeBNG4vNDN385pqEwTgGhp8gfTEIF1 rDnVlkc5+TxhH80AxQQikMxQV+/Mobg5+JqgY31ruwLCE9oj5j3YhY+5B+Nx7cJUmxHu ZnleMOcK+iPQKrEcvCjSltemwIyc+sdiAvljXQh2YsF1FdpU0yDHLYuO7IsjVktd7eG1 euhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XeTf4A7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e10si2995260ejy.205.2021.06.18.12.51.04; Fri, 18 Jun 2021 12:51:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XeTf4A7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234941AbhFRTWP (ORCPT + 99 others); Fri, 18 Jun 2021 15:22:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:33838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234386AbhFRTWO (ORCPT ); Fri, 18 Jun 2021 15:22:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id 0887461264; Fri, 18 Jun 2021 19:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624044005; bh=Xqb8RBZ0ASq4yOAuloDrF09hxGXS96TfbcRI+gmXw9Y=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=XeTf4A7zIRZ74HkMH85S1qmVpDNOdMZkU0YGDM23QMbEspRqCv5ggbFNBIAv7elqx PUXwT2QHqI5sy+t8tXYFIctj9xjBStvQxfqxRXC+zN1c+TA/15yQRJhpn73NPoUu3J X9liQa0S1gBA++irh5sFqHIV+2xyP8nbDb8gkdyEyhpSqGLV4RSQVsteg7IjaCJCLf aHLUsOKmczJNQbFYBiLDf+rN4F1A7uS1LGCcAQAscliz2HiVE8Dqw4CHy7X7Fb4gaq +mnHRekmAyTZfUyT6M+X5ubUxkmmdvZUnORzT4S1HBN6Aftt+M5d92z+v021T1qC/v nGaTijIMPC9pw== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id EAF8F609D8; Fri, 18 Jun 2021 19:20:04 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH 1/4] net: ll_temac: Make sure to free skb when it is completely used From: patchwork-bot+netdevbpf@kernel.org Message-Id: <162404400495.12339.18313933113853867877.git-patchwork-notify@kernel.org> Date: Fri, 18 Jun 2021 19:20:04 +0000 References: In-Reply-To: To: Esben Haabendal Cc: netdev@vger.kernel.org, stable@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, michal.simek@xilinx.com, jesse.brandeburg@intel.com, wanghai38@huawei.com, andrew@lunn.ch, zhangchangzhong@huawei.com, michael@walle.cc, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This series was applied to netdev/net.git (refs/heads/master): On Fri, 18 Jun 2021 12:52:23 +0200 you wrote: > With the skb pointer piggy-backed on the TX BD, we have a simple and > efficient way to free the skb buffer when the frame has been transmitted. > But in order to avoid freeing the skb while there are still fragments from > the skb in use, we need to piggy-back on the TX BD of the skb, not the > first. > > Without this, we are doing use-after-free on the DMA side, when the first > BD of a multi TX BD packet is seen as completed in xmit_done, and the > remaining BDs are still being processed. > > [...] Here is the summary with links: - [1/4] net: ll_temac: Make sure to free skb when it is completely used https://git.kernel.org/netdev/net/c/6aa32217a9a4 - [2/4] net: ll_temac: Add memory-barriers for TX BD access https://git.kernel.org/netdev/net/c/28d9fab458b1 - [3/4] net: ll_temac: Fix TX BD buffer overwrite https://git.kernel.org/netdev/net/c/c364df2489b8 - [4/4] net: ll_temac: Avoid ndo_start_xmit returning NETDEV_TX_BUSY https://git.kernel.org/netdev/net/c/f63963411942 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html