Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1886912pxj; Fri, 18 Jun 2021 19:20:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7NQj+sl+C/QBRW4gCgIXd5C/UQGdZlYVATnio7UME2yUwmRWYacaZPP0pl05pnrr6FjFg X-Received: by 2002:a5d:858d:: with SMTP id f13mr3744728ioj.121.1624069219638; Fri, 18 Jun 2021 19:20:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624069219; cv=none; d=google.com; s=arc-20160816; b=Gv1D/SCzWEhc7eF0lfU1Yppv9N4DITzwr+AH24FsND0suUIIUvMd+JJK8Dst/6X4i2 KWgsoPNf8509rgwFGrk0ZoH41nbJYd9W44ViiLBpEFziVcrsgoHXsb7I8VGx9jeBMJLD zCeadBueyU7Hn8EpHF9eb+1dDV4ZgryAVSZr9Tnt1FkeZvnZ2YMaNZcIEJQzGReyw376 PQnf/CR2ifI7ED2r3bBhcnkU5v7goYFaLES8hp6WA8XbRUBWZY2tQftJ6BbqmYJwbRc9 3pKwychctzeQaAUi05upQLGVLxL9+eqvrGnWsfLKC20Px7unqqnYfZlbhCbwD8b49j9Y /xww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=efZiryzTZwErGPG9eUAqI8R5gBkZ9//XEzY7JmzlBZo=; b=JSHqcN/b9UeOnB4Tj/uFQEKfB5AWByICxJthuweV8TmthkAYUYq1W2JJ7ydQmZHW4X mlm6WbzocY96/3nnb+2ve7CSjiwkSYGVsPFknfg93kJ78qLY/O3GDUHaHiqCvE0hk3cK ONhwjuyupaa8UK0xhwtYc8pC/2RAhVLRlayCk4Hp6gN2IJ2YrTXP1GnnzKvPiKX4X4dQ h32pz8ngSJzjIvQ6tZT4ySY0Cpxw4UcUM0h4hC/XkfspnT6VAgT2wk9sIG6M+VGL2ETQ YgbFw3NMy5Hafx88ZJHGathe1ZpJsgz4uTqjjJ47AdgM6uM9Vl12Cgq2Lwh1Q76E8ziC qikQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=meopqwHK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si12420719ioh.104.2021.06.18.19.20.08; Fri, 18 Jun 2021 19:20:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=meopqwHK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233158AbhFRTkO (ORCPT + 99 others); Fri, 18 Jun 2021 15:40:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbhFRTkN (ORCPT ); Fri, 18 Jun 2021 15:40:13 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5343CC061574 for ; Fri, 18 Jun 2021 12:38:03 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id e33so8622645pgm.3 for ; Fri, 18 Jun 2021 12:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=efZiryzTZwErGPG9eUAqI8R5gBkZ9//XEzY7JmzlBZo=; b=meopqwHKty7urd9b/j/Syk7Hqvgj8LIJzopjpDceO3tXr+t/JjTvgpVzEIt8uur/bp O4eAQOwv1Q1O2tSsR1bL2LjV+gvhBtFhSw3AcI/BiX8JKjzOU3GC1ZuWT4jwQyqJVK4f YHl1xy78/znRIqh0soZANGYuQ6uuJDY5SBAjjNaDr76WhQ5Llt3HHGsI4xMurqsfEGAY Pl/UZYWtI5Wg54bCsMDFmO2P9hlwL39PbVIGynY/hkpfDDOsf9ngxppFwvwtu+VIa8Q/ 0Ey4CO7ebVOxUsJbDvwfIujUfnkmlELjGteOiDT/o4jZc+oSba1qBzqXmfOTQvjESqDP YNdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=efZiryzTZwErGPG9eUAqI8R5gBkZ9//XEzY7JmzlBZo=; b=tv9wtcheJFSbcrUrfxwQ4OAiwMyYJukAOASZh9UySPHBxwYXAtKAgbP25EJrVv+PKn 6WrQ87oLszq5FXQFgFo+pg1EVSfgEPBK2vVsK9NHCcu74mkW0+BRxFb519W814+BozHi TOVcL9C6Swhz5XSol6RMgc/In2o69FmggJzhZL+ibRG9amEPpZZLcS7pZQvQAnJwvUIm hcXEEh6xGJTRz1wGbbTAKZvzsbMvh2+jUyyUb+Re+YeoujhJOWynX/KQLgm6QLtXbPCP sjXiwTtTFA/OH965NH1/GLETWZgHbt0gEwZQnI1twRbopGw5RRyEncB203RDUBe/nOME qhuw== X-Gm-Message-State: AOAM533SKPNIdJShq8Vxnhuquw4HA/CSf4615+Lay7dIKvC/qexLbUcy 57IfD0m10HzdVU1RqUcxIPejiQ== X-Received: by 2002:a62:be03:0:b029:2e9:fe8c:effe with SMTP id l3-20020a62be030000b02902e9fe8ceffemr6563096pff.34.1624045082626; Fri, 18 Jun 2021 12:38:02 -0700 (PDT) Received: from [2620:15c:17:3:3a6:a5d0:1984:a150] ([2620:15c:17:3:3a6:a5d0:1984:a150]) by smtp.gmail.com with ESMTPSA id y2sm8510157pfa.195.2021.06.18.12.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 12:38:01 -0700 (PDT) Date: Fri, 18 Jun 2021 12:38:01 -0700 (PDT) From: David Rientjes To: Georgi Djakov cc: vbabka@suse.cz, akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, penberg@kernel.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, djakov@kernel.org Subject: Re: [PATCH] mm/slub: Add taint after the errors are printed In-Reply-To: <1623860738-146761-1-git-send-email-quic_c_gdjako@quicinc.com> Message-ID: <413080c2-bfd7-f386-709c-43718242ae87@google.com> References: <1623860738-146761-1-git-send-email-quic_c_gdjako@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Jun 2021, Georgi Djakov wrote: > When running the kernel with panic_on_taint, the usual slub debug error > messages are not being printed when object corruption happens. That's > because we panic in add_taint(), which is called before printing the > additional information. This is a bit unfortunate as the error messages > are actually very useful, especially before a panic. Let's fix this by > moving add_taint() after the errors are printed on the console. > > Signed-off-by: Georgi Djakov Acked-by: David Rientjes