Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1914698pxj; Fri, 18 Jun 2021 20:26:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOfB/0O4mDPtGu1bkiViFPcJ2rGOr8ctspQ2WUp9iLRzPf0j4M7/GUjc4R+1VsCGrFB8fR X-Received: by 2002:a6b:760e:: with SMTP id g14mr10519813iom.119.1624073194085; Fri, 18 Jun 2021 20:26:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624073194; cv=none; d=google.com; s=arc-20160816; b=KHxKim5RuYCD36RTsIrZLVUTzS2PQi3qgERLZGHh7Pne7B0VGorbeVVD05gXX4XD5K nzwqa0iA15VJjADmAqjClFqbIPB5mXRN7zUeXebJ9EeSxRDh5ChokRV7qc0cHZIVQw2N VZ5Yzk4MM6wpyGkk2TPFvFExh7aE2M67hhsQxRaVgCjRdndQqVnETxm727tgCz7AE2OT pKRiyfG4FWp4YbtfSTTa5SQWHYe7Oou688dTP0DNEc5Xfg4lvGF2FzKpHZhMhrlYPN1V yXS6hSlLqLG7y1PPD6z6BH6flI+6H3PPMjaorQ7oeeiK9rzoMB0oCqrT6oXwVKbIayOR mF/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=HCbMagHOcQkRZg7z8V2JaZXZkYjyE7xiQasiBsLKpqQ=; b=an0yDl9dxop9YA8XTz0M2bw/u5bFHufKq4pYj79pCJS2JNrBhpiImdZSCiCQG+2QSz ClH2rlUKrvodQdg5bVYFCDGWS2PTRUaWnh8AerVSZYB83OC+2BNJjmUYMlr2zVtwL8/p /B5skRIevFOU9J1FoeoWGGQ6zeqlaMQwJazLY8zTRl4AfeRwKMPleKknQoqTVdNH1Bu1 /fWDdcJQJFnlMQEDRxTTfFZ99fDKbWGPQmcLEs9OJdzqel7u8lB6FL074aNRXeQX99D6 JtLaH30ovi4FKIQ/w3rG4xpfO1oeehqNbKgy+MxDAWtuQQHxG9h46nsRtv2iQjWiRp5i Rqdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w15si3874151ilv.111.2021.06.18.20.26.00; Fri, 18 Jun 2021 20:26:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234028AbhFRTG4 (ORCPT + 99 others); Fri, 18 Jun 2021 15:06:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:58942 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbhFRTGz (ORCPT ); Fri, 18 Jun 2021 15:06:55 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9BBD560FF0; Fri, 18 Jun 2021 19:04:44 +0000 (UTC) Date: Fri, 18 Jun 2021 15:04:43 -0400 From: Steven Rostedt To: Daniel Bristot de Oliveira Cc: Phil Auld , Sebastian Andrzej Siewior , Kate Carcia , Jonathan Corbet , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Alexandre Chartre , Clark Willaims , John Kacur , Juri Lelli , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 12/12] trace/osnoise: Support hotplug operations Message-ID: <20210618150443.44a49826@oasis.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Jun 2021 11:28:51 +0200 Daniel Bristot de Oliveira wrote: > @@ -1566,7 +1627,14 @@ osnoise_cpus_write(struct file *filp, const char __user *ubuf, size_t count, > osnoise_tracer_stop(tr); > > mutex_lock(&interface_lock); > + /* > + * osnoise_cpumask is ready by CPU hotplug operations. I don't understand the usage of "ready" above. Lost in translation? * osnoise_cpumask is updated by CPU hotplug operations. ? -- Steve > + */ > + get_online_cpus(); > + > cpumask_copy(&osnoise_cpumask, osnoise_cpumask_new); > + > + put_online_cpus(); > mutex_unlock(&interface_lock); >