Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] s390/vfio-ap: Fix module unload memory leak of
 matrix_dev
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     "Jason J. Herne" <jjherne@linux.ibm.com>,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        pasic@linux.ibm.com
References: <20210618171255.2025-1-jjherne@linux.ibm.com>
 <af3d6c67-e045-770f-82ff-dd8e691c1317@linux.ibm.com>
 <20210618182336.GJ1002214@nvidia.com>
From:   Tony Krowiak <akrowiak@linux.ibm.com>
Message-ID: <1a951d33-e1bc-d23f-36e1-4987c661c7a9@linux.ibm.com>
Date:   Fri, 18 Jun 2021 16:05:40 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210618182336.GJ1002214@nvidia.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 6/18/21 2:23 PM, Jason Gunthorpe wrote:
> On Fri, Jun 18, 2021 at 02:11:23PM -0400, Tony Krowiak wrote:
>>
>> On 6/18/21 1:12 PM, Jason J. Herne wrote:
>>> vfio_ap_matrix_dev_release is shadowing the global matrix_dev with a NULL
>>> pointer. Driver data for the matrix device is never set and so
>>> dev_get_drvdata() always returns NULL. When release is called we end up
>>> not freeing matrix_dev. The fix is to remove the shadow variable and get
>>> the correct pointer from the device using container_of. We'll also NULL
>>> the global to prevent any future use.
>>>
>>> Signed-off-by: Jason J. Herne <jjherne@linux.ibm.com>
>>>    drivers/s390/crypto/vfio_ap_drv.c | 5 ++---
>>>    1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
>>> index 7dc72cb718b0..40e66cb363d1 100644
>>> +++ b/drivers/s390/crypto/vfio_ap_drv.c
>>> @@ -82,9 +82,8 @@ static void vfio_ap_queue_dev_remove(struct ap_device *apdev)
>>>    static void vfio_ap_matrix_dev_release(struct device *dev)
>>>    {
>>> -	struct ap_matrix_dev *matrix_dev = dev_get_drvdata(dev);
>>> -
>>> -	kfree(matrix_dev);
>>> +	kfree(container_of(dev, struct ap_matrix_dev, device));
>> I suppose if we're not going to assume that the release is being
>> called to free the global matrix_dev, then if you are going to
>> retrieve it using container_of(), then maybe we should verify
>> the retrieved pointer is the same as the global matrix_dev?
> That seems like overkill to me

After thinking about it, it's probably more than overkill as I
assume the container_of() function would fail if dev was
not contained in matrix_mdev:

Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>

>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
>
> Jason