Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: KOKr1pCYd6Ok4WMSDDG9D83H9i11LwOb9Tsy+d/dF4U399fAnY4TapncIFNb/vrhwOpeWdkEwm
 BFI5KJZ41Tag==
IronPort-SDR: 3AkLfnkZ8KxBn/rjNDGUd9DTtojx7p7i/6Xa0PuH8GQ42RtupwJpX2mhtGnVZPHbmOsFCUrg9a
 DIZlBF3nomxg==
Subject: Re: [PATCH v3] x86/resctrl: Fix kernel-doc in internal.h
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        linux-kernel@vger.kernel.org
References: <20210616184330.13301-1-fmdefrancesco@gmail.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <9100bce9-d27f-23e7-f5b5-2a6468a6b3bd@intel.com>
Date:   Fri, 18 Jun 2021 13:37:08 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210616184330.13301-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Fabio,

On 6/16/2021 11:43 AM, Fabio M. De Francesco wrote:
> @@ -78,10 +79,13 @@ struct mon_evt {
>   };
>   
>   /**
> - * struct mon_data_bits - Monitoring details for each event file
> - * @rid:               Resource id associated with the event file.
> + * union mon_data_bits - Monitoring details for each event file
> + * @priv:	       Used to store monitoring event data in @u
> + *		       as kernfs private data
> + * @rid:               Resource id associated with the event file
>    * @evtid:             Event id associated with the event file
>    * @domid:             The domain to which the event file belongs
> + * @u:		       Name of the bit fields struct
>    */
>   union mon_data_bits {
>   	void *priv;

This hunk continues to be whitespace broken. You are adding tabs when 
existing comments use spaces. Please ensure that your changes fit with 
the current style in this area.

Reinette