Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] scsi: elx: efct: Do not use id uninitialized in
 efct_lio_setup_session()
To:     Nathan Chancellor <nathan@kernel.org>,
        James Smart <james.smart@broadcom.com>,
        Ram Vegesna <ram.vegesna@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     Nick Desaulniers <ndesaulniers@google.com>,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
References: <20210617061721.2405511-1-nathan@kernel.org>
From:   James Smart <jsmart2021@gmail.com>
Message-ID: <bd2d2be8-8ec9-601a-14d6-aa4edb92859c@gmail.com>
Date:   Fri, 18 Jun 2021 15:52:20 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <20210617061721.2405511-1-nathan@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/16/2021 11:17 PM, Nathan Chancellor wrote:
> clang warns:
> 
> drivers/scsi/elx/efct/efct_lio.c:1216:24: warning: variable 'id' is
> uninitialized when used here [-Wuninitialized]
>                        se_sess, node, id);
>                                       ^~
> 
> Shuffle the debug print after id's initialization so that the actual
> value is printed.
> 
> Fixes: 692e5d73a811 ("scsi: elx: efct: LIO backend interface routines")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1397
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>   drivers/scsi/elx/efct/efct_lio.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 

Thanks

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james