Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zev Weiss <zweiss@equinix.com>
To:     Andrew Jeffery <andrew@aj.id.au>
CC:     "openipmi-developer@lists.sourceforge.net" 
        <openipmi-developer@lists.sourceforge.net>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
        "minyard@acm.org" <minyard@acm.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "tmaimon77@gmail.com" <tmaimon77@gmail.com>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "avifishman70@gmail.com" <avifishman70@gmail.com>,
        "venture@google.com" <venture@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tali.perry1@gmail.com" <tali.perry1@gmail.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "chiawei_wang@aspeedtech.com" <chiawei_wang@aspeedtech.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "benjaminfair@google.com" <benjaminfair@google.com>,
        "arnd@arndb.de" <arnd@arndb.de>, "joel@jms.id.au" <joel@jms.id.au>,
        "KWLIU@nuvoton.com" <KWLIU@nuvoton.com>
Subject: Re: [PATCH v4 11/16] ipmi: kcs_bmc: Add serio adaptor
Thread-Topic: [PATCH v4 11/16] ipmi: kcs_bmc: Add serio adaptor
Thread-Index: AQHXZJnjCtcI+6c1UkiVQLPff6oAew==
Date:   Fri, 18 Jun 2021 23:30:13 +0000
Message-ID: <20210618233012.GD9658@hatter>
References: <20210608104757.582199-1-andrew@aj.id.au>
 <20210608104757.582199-12-andrew@aj.id.au>
In-Reply-To: <20210608104757.582199-12-andrew@aj.id.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wLlVoZTi2nmpoaqObUFJngTyLhb+DTPJnqhr4u6xQSfgwYd+TGKfrMa42Xbw?=
 =?us-ascii?Q?9oO9rMqMI4KEyIteDjTPjzzfOrXbsNJoCEWJvpGfnXPwD2PkS//qow37MAmZ?=
 =?us-ascii?Q?o+6kAR/YbHQqfEA4OT/nJ9XpkT8rQWNospWrAMtZxLioZIe5V9HLbuWmmrvg?=
 =?us-ascii?Q?mgHKGgiVoknDqdg4+cUwS5vRMrRkWMQXAbLlpuDeu31PtP9qGVjRxd191YXh?=
 =?us-ascii?Q?d29+UwxXhlzhvV1i+Q6g47qgVHhIsGuFY3alocizflPREKQ3qHA1o47lEXJp?=
 =?us-ascii?Q?ysGT/VfQt1Gi1drA4rrjRsIOnQ5b9KBILeF7nS8mi7gJfMgYU0g6ShJk+RrQ?=
 =?us-ascii?Q?Ss4bsSBlOUTJmS35/QybsaPgqeenPiNPOlLqwyco+5xtNcOoERHtZf5GRwq2?=
 =?us-ascii?Q?jSWMWZn6ZhxF4iI7/UplTJDYd6r9ErS36YUeTfBHJknp7q8GMBZM82urWTPw?=
 =?us-ascii?Q?9hD9TZVr4FF6FiVayGymIbdd6LQV78u4XR5UZYRrM0vQsD1M1aYsjnI/e+ZV?=
 =?us-ascii?Q?Dn4nRtg/Exk/cMJQkraalJ6CrJkWOcEKr0bVrzrTPXOhjsnefo6n1HzMgcYN?=
 =?us-ascii?Q?1HDs+2JR8TArqCyLfx9V1Zf+uSy6dwbYLLvD10HntKgUw7J7ijuuoRYds6jJ?=
 =?us-ascii?Q?F4s/NjJp9bluP85JNcQi1ikJpEt4LXzY2XQ9rSDrj0F01ePXxF2ul43DiSzZ?=
 =?us-ascii?Q?Q49D7VLkDxfmp/mQw3nqk/1ZZP3ZCOsV2weB6zQihKGUugYartdYwdh9sJCK?=
 =?us-ascii?Q?V7rNEUItxGq2g12e3VmiyKSofcpXYchSBZhuSvK+z2IB1LEM/JiD8f89lMH1?=
 =?us-ascii?Q?t8KxH948XO0cgWvkbkgMxeA8M+8KRaLYeI5RqJh0gB0Emq/Nfs/Chm1ixBQf?=
 =?us-ascii?Q?5pKe2xHpJjaEe/fG5fbF3+Yq9Ux0uOAWTUAJeo10J8lgDzKq9nuNsTK995UB?=
 =?us-ascii?Q?nIEegJ9/Sffs3Yy+U+TDyptc0S7krn6FCgTMTi62iEJ+CLT+If0C8CVy4XPV?=
 =?us-ascii?Q?85zmOGcCX0g8lRLB1P4Lt+plcAX5wD658bVe0cZN1YZuHztnC8PgDOiitq4j?=
 =?us-ascii?Q?YGKe5O74ZILJ0EdV1YAnkKKN7M1yBkiROVu7pmxnTCAMHDzuBr17J8dt01Zr?=
 =?us-ascii?Q?xaRnOqpooAF8w6TzuO/ZjV7XeFNhq+xBPP9RQ/quUCZcISrJOSNoOPM5WQhx?=
 =?us-ascii?Q?6zBvAk9shhDa181CbBUF2qLOyY6kLPz8myJRFAFQrffuL/1zxEAPRNmr/R6E?=
 =?us-ascii?Q?l/FLzQNAb3j7aFnih8IOhWLvxYFI7aOiJexmIcm3DwnHoHSwr39V6jDNT/3d?=
 =?us-ascii?Q?0DlXMqhTh89bEsy1Vj4JBCR4?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4C7CA56F6280F64E8D353493A56DCA13@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: equinix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR04MB0762.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7290dbcc-b93b-4cd7-9ffb-08d932b105bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2021 23:30:13.5810
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72adb271-2fc7-4afe-a5ee-9de6a59f6bfb
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hu4g4tA65HooJ9eXtlPTnRg2qYgN0RxQqG6vJLO2nwFBUBAbCm1wfbmy6sYyXb5E9/dERBRE9uYuanm7isy0UQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6732
X-Proofpoint-ORIG-GUID: 5yjc8PaMATy4AdprkR739qDMudB5yGED
X-Proofpoint-GUID: 5yjc8PaMATy4AdprkR739qDMudB5yGED
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-06-18_12:2021-06-18,2021-06-18 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 impostorscore=0 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0
 malwarescore=0 clxscore=1015 spamscore=0 mlxlogscore=999 bulkscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2106180137
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 08, 2021 at 05:47:52AM CDT, Andrew Jeffery wrote:
>kcs_bmc_serio acts as a bridge between the KCS drivers in the IPMI
>subsystem and the existing userspace interfaces available through the
>serio subsystem. This is useful when userspace would like to make use of
>the BMC KCS devices for purposes that aren't IPMI.
>
>Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>---
> drivers/char/ipmi/Kconfig         |  14 +++
> drivers/char/ipmi/Makefile        |   1 +
> drivers/char/ipmi/kcs_bmc_serio.c | 157 ++++++++++++++++++++++++++++++
> 3 files changed, 172 insertions(+)
> create mode 100644 drivers/char/ipmi/kcs_bmc_serio.c
>

Reviewed-by: Zev Weiss <zweiss@equinix.com>