Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210618040639.3113489-1-joel@joelfernandes.org> <YMxagWy/Ioj3aere@hirez.programming.kicks-ass.net>
In-Reply-To: <YMxagWy/Ioj3aere@hirez.programming.kicks-ass.net>
From:   Joel Fernandes <joel@joelfernandes.org>
Date:   Fri, 18 Jun 2021 20:33:27 -0400
Message-ID: <CAEXW_YQVu9rN04voYUSWiRrzNxa+nQyNMaTyreOuBn96B8yNSg@mail.gmail.com>
Subject: Re: [RFC] schedutil: Fix iowait boost issues for slow I/O devices
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ingo Molnar <mingo@redhat.com>, Josh Don <joshdon@google.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Mel Gorman <mgorman@suse.de>,
        Qais Yousef <qais.yousef@arm.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jun 18, 2021 at 4:34 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
>
> Aside from everything else:
>
> On Fri, Jun 18, 2021 at 12:06:39AM -0400, Joel Fernandes (Google) wrote:
>
> > +unsigned int sysctl_iowait_reset_ticks = 20;
> > +unsigned int sysctl_iowait_apply_ticks = 10;
>
> Never expose HZ to userspace. we even have USER_HZ (no new usage please)
> that fixed existing problems with that.
>
> If you expose a knob, make it in sane time units and convert internally
> to whatever you need. That said; less is more with knobs.

Sorry, you are right and good idea. I will look into making such a
modification while I wait for comments from others as well on rest of
the patch.

thanks,

-Joel