Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zev Weiss <zweiss@equinix.com>
To:     Andrew Jeffery <andrew@aj.id.au>
CC:     "openipmi-developer@lists.sourceforge.net" 
        <openipmi-developer@lists.sourceforge.net>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
        "minyard@acm.org" <minyard@acm.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "tmaimon77@gmail.com" <tmaimon77@gmail.com>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "avifishman70@gmail.com" <avifishman70@gmail.com>,
        "venture@google.com" <venture@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tali.perry1@gmail.com" <tali.perry1@gmail.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "chiawei_wang@aspeedtech.com" <chiawei_wang@aspeedtech.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "benjaminfair@google.com" <benjaminfair@google.com>,
        "arnd@arndb.de" <arnd@arndb.de>, "joel@jms.id.au" <joel@jms.id.au>,
        "KWLIU@nuvoton.com" <KWLIU@nuvoton.com>
Subject: Re: [PATCH v4 06/16] ipmi: kcs_bmc: Split headers into device and
 client
Thread-Topic: [PATCH v4 06/16] ipmi: kcs_bmc: Split headers into device and
 client
Thread-Index: AQHXZJkPf4dJkq3NYkm0gW8CBK/BRA==
Date:   Fri, 18 Jun 2021 23:24:17 +0000
Message-ID: <20210618232417.GB9658@hatter>
References: <20210608104757.582199-1-andrew@aj.id.au>
 <20210608104757.582199-7-andrew@aj.id.au>
In-Reply-To: <20210608104757.582199-7-andrew@aj.id.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1jlczRx3Nr6X/cDZszekOD4elulbwWfABv8XKNW1/gFcYOqCiVh8bdPlljzp?=
 =?us-ascii?Q?f7bQAE4OLZI0gwjGkbhN+HULa/L59SGmrD/l2ifxZ1vhOtxmtFfkMG70SZ4K?=
 =?us-ascii?Q?EDFP+htuikJfFbf0i4D3DZGTCBYVxOUWHZqlPgtQVGimPbogU7sfx8rmf8Ue?=
 =?us-ascii?Q?MtsM2GS3sax+VWQf6b28OH6nWo0v7nt1TfNC47BbCht4BFoF1TEwqWuWdiK5?=
 =?us-ascii?Q?+sYvXQrPETKcQej4cidWLwcHzUcUsHgO6oH3cOlLQlUJmMuHkzVmxIlQbQ7c?=
 =?us-ascii?Q?MjDB9zGPkt5W5ID+AJ+YWm5BTPQ7cteW/dudhD2d8Qi+edlcOOjclO94nM4y?=
 =?us-ascii?Q?9X7EbZYubbv+ahXvJKFVEtP502mQb3xg1VHdhZWg71UgHf6Rh5l8gFrHkQq4?=
 =?us-ascii?Q?PFXOnpuJxQD9QObNEGMCQsvPcCbKima3xWZoG+raD24Dm4n2rGooFqCfa3Fw?=
 =?us-ascii?Q?gSkT5tMbiWiOB0VNfQi8yeKXOYkSGZoeQhX8KFQL2CFL6/ydh7lVIAg1+AQU?=
 =?us-ascii?Q?IEPcWeANlyjJqwz8676bnyP9iXDu6pUeFhczLUc4WOtFv6JArVKxAm2fxh6V?=
 =?us-ascii?Q?/CDGfXrx3wJjTe/3OTpJpcG+QslrylZDyOAG0jACNpNVfK6IyNXoxqZL4P7Y?=
 =?us-ascii?Q?m9Oc87HiJufZJSfiFmswTd0Wtwts9/u0C1fDRfJBXeN+/FxVkRc/VTfBaZ59?=
 =?us-ascii?Q?njOtygzGqAPSTexbi4Sif4UXb76uxsaAeUx/3UWxEPDDXQqbYF3BvrPQ0sH1?=
 =?us-ascii?Q?DSMK/izHgCWw7CpcDhRxdgzxD661ZHphvlqT2D535i5A3yj3Zjl0KlyfVnCW?=
 =?us-ascii?Q?kH5EIIWDCmHdJnPUtekBMSqV0no6kZyrokuPm/EYbYb6X0Mrv7XhjKcdlKdy?=
 =?us-ascii?Q?gTRxu/BVqsc7PhH8D4Rn2+xWM5GGAWLpmyiE6vfgrqw7AQb7UemGahd4gjd5?=
 =?us-ascii?Q?k81AZasTyx37vnMyDKK/DLLXVJzHpKIJMTscLLgYywPo8WXbVWnrbtEou50i?=
 =?us-ascii?Q?GTmgMU4sbq62kE6KVbpSSGeTzV1eH6EnXPk//LCDnRl12Ub/XsNAYp3m00zi?=
 =?us-ascii?Q?Qdxx5ysCGi3qj0v23NzFZUlbyFpJvZmKWCR9yfWror7fxMO1fLJBjR+t9FhX?=
 =?us-ascii?Q?soCjyoWoRryVRzTPnUVODFUwWFSDsaPeu/rfUm/ehZgDzD65TfO0rOYvCUc5?=
 =?us-ascii?Q?MO0epdde5ito/inlFw8ldQQ3PuTpQcb7LRxAT1jCGu7IImH5V8PbSZvF4Ofu?=
 =?us-ascii?Q?Ej8iBZNgEqFkvvRMdSUKe8VaCk4Io7YChQwP1Y4Dl5MD3Oxwxg1luhNXLRDx?=
 =?us-ascii?Q?z1WjGI594Uyd4r/wycw1nJT4?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7C46CDA014F727418116BC7CE0ECD04A@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: equinix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR04MB0762.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d74ba7f-035f-4754-c821-08d932b031c4
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2021 23:24:17.9239
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72adb271-2fc7-4afe-a5ee-9de6a59f6bfb
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VcCNgAfPJ+4M6N/ALziakWNoZ6HGm9x4W43kbGakJN27+P58SIH7GF6J8hNch/CwKOoBHS0adkRe/6hRc/cFXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1212
X-Proofpoint-ORIG-GUID: SPvOQKaS_FmkLyFadmht4Kh-83xxzEMF
X-Proofpoint-GUID: SPvOQKaS_FmkLyFadmht4Kh-83xxzEMF
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-06-18_12:2021-06-18,2021-06-18 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 impostorscore=0 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0
 malwarescore=0 clxscore=1015 spamscore=0 mlxlogscore=997 bulkscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2106180136
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 08, 2021 at 05:47:47AM CDT, Andrew Jeffery wrote:
>Strengthen the distinction between code that abstracts the
>implementation of the KCS behaviours (device drivers) and code that
>exploits KCS behaviours (clients). Neither needs to know about the APIs
>required by the other, so provide separate headers.
>
>Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>---
> drivers/char/ipmi/kcs_bmc.c           | 23 ++++++++++------
> drivers/char/ipmi/kcs_bmc.h           | 27 +++++++++----------
> drivers/char/ipmi/kcs_bmc_aspeed.c    | 17 ++++++------
> drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 39 ++++++++++++++++++---------
> drivers/char/ipmi/kcs_bmc_client.h    | 27 +++++++++++++++++++
> drivers/char/ipmi/kcs_bmc_device.h    | 19 +++++++++++++
> drivers/char/ipmi/kcs_bmc_npcm7xx.c   | 17 ++++++------
> 7 files changed, 117 insertions(+), 52 deletions(-)
> create mode 100644 drivers/char/ipmi/kcs_bmc_client.h
> create mode 100644 drivers/char/ipmi/kcs_bmc_device.h
>

Reviewed-by: Zev Weiss <zweiss@equinix.com>