Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     James Smart <james.smart@broadcom.com>,
        Ram Vegesna <ram.vegesna@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in
 efct_hw_command_cancel()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1wnqqy481.fsf@ca-mkp.ca.oracle.com>
References: <20210617063123.21239-1-nathan@kernel.org>
Date:   Fri, 18 Jun 2021 22:32:05 -0400
In-Reply-To: <20210617063123.21239-1-nathan@kernel.org> (Nathan Chancellor's
        message of "Wed, 16 Jun 2021 23:31:23 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.ca.oracle.com (138.3.200.58) by SN7PR04CA0166.namprd04.prod.outlook.com (2603:10b6:806:125::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.19 via Frontend Transport; Sat, 19 Jun 2021 02:32:08 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c36ce010-633b-47db-d39b-08d932ca6f9b
X-MS-TrafficTypeDiagnostic: PH0PR10MB4533:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB453302F440069FFB37AFD0448E0C9@PH0PR10MB4533.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UygMH1RgSlrfFdBs2z6YRm1f2fPSvIQ1l3HupHoJYDZ0ZOL+2SSnbDMmrG0HRii5K1/5Bm156N2Fya1pXuV8sgIue7m4PFLMKcAFGqlbUU6Gl+9JqoVMTUv53WaiN8O9Q6XoLwaxsFKsenHoc2VHVoUqrc1Ko4SDUj3HmVopjCQCeAfk7HpLXcBsB5m41k8n1NA3Xxkf911p9T99m9oa10q6eKUrWN8Gw4VGkaEIxn9lAE7WvcthNNsnYfAZZR5HlDLtp3d0HFGdYV/jgnTZWkkEC0q+abQGT7tLxx7hLAnW0xstdkpn2FE5DeIbD1LVhc4CFwo3Qp+yYuZWa2qJ2zUL1Y2KeuVFlLHm1TQpMp3akj5L+jeon8cMaMfe8ie2SQVbHblhfZFkZQpwUy63Kdm/3s0qisr8UwbySL7xkGwN687uGxoOQMcBaz7TxMjenJMLefLf7DLqYSIY/4TVwZMs1QiujLa5FXddP0h+nF87imoiNfEDQFT0TSvlNu8MeLjy5TiLdO5+FWMW3PcDxlyaLqDjYbsD5fP2L/yezOWYKLXihU3XOF7F2IfO10EDx93Rw9IHfEsjBCyKY/8kb/8mCnz/EJ4BrqsTVNx/rfu7u0xdtNkEnVXzFJGKYWM3CEWuAXjD3OGucTR5NCCHIA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(376002)(39860400002)(396003)(366004)(6916009)(8936002)(86362001)(478600001)(5660300002)(8676002)(54906003)(4744005)(52116002)(6666004)(36916002)(38100700002)(55016002)(26005)(38350700002)(4326008)(2906002)(316002)(956004)(83380400001)(186003)(66556008)(7696005)(66946007)(16526019)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7+H7OgmgS+J02Y3Z5I+rq22Rr/HBmtBblOSyVrwL8T7FZAiUBDLRZ4Rss+1x?=
 =?us-ascii?Q?S08V/KPKqajG9J1x0njv89cM5gZ2Bif0lCDS9rp7Z7EZint8xCSL46//H0cR?=
 =?us-ascii?Q?dZdy8qgwo8+qe9VjgcmizL2LQxG+/GJVp3lcVjRkJ6jVOyHgQF5JaqgvzBYm?=
 =?us-ascii?Q?8nUFTl+SJ75EaoBXioN1ProrqjEidqANtqYewU5cLv7MR/Y5VBWKIRtZ+fhD?=
 =?us-ascii?Q?Quc409ib8TAt5TI10qQLFWhIgncQeKwktY47YzDgGWqNZQ8n3mjzk6Y5qxHd?=
 =?us-ascii?Q?8xr7Bjz7QOe1gIN31wg1wsOVWnwhGa/bGqFC84yfVmnWWTtDH9jFchaSAl2S?=
 =?us-ascii?Q?hPLDdBddeCz7xC53diuZutj1F9VoS8it+mp8tFLZ+a5M0ofg7DHqSFGCkS3p?=
 =?us-ascii?Q?h0Uu643pW7shaqcwqrDQzc5ivZbFKKfkZ/4W5BTwkyOEJCBE9yeQmHDeOs4R?=
 =?us-ascii?Q?4iLekv7Tce9vh+gqOODOzhbEXI+04rKsJdbmjqx30gNVzaW6S1SPN4Ymcvaf?=
 =?us-ascii?Q?dD5lDScWQIETTPv11yft3h0sJ6U+q8u7BoVMYiM0XABVrzF5HTGvWIX+3xyt?=
 =?us-ascii?Q?PpO1oJcKaPXb7hqMWUVxO3n3XAqbrZBoLHGrX71GlF0x8lwy/s9UnoL4NnM9?=
 =?us-ascii?Q?h59JMV0P15gtwrD4+ddX7bOuXQsDlP22NzGuDwaMKWm8G3yBxV1m97kNTIC6?=
 =?us-ascii?Q?m6Zmz1EboLPljcdDcULv5yB6iUhtl87+0xise/JmC0xlp5nSO0NWjVooCsY1?=
 =?us-ascii?Q?g1xSgcuZsSmqtQftuN6G4joQU08vIDVDeiis+i8dZLnNuk4v4/NC0w4k0+AT?=
 =?us-ascii?Q?vuQk6HGDu52eZpUzC9wCeoM6ls/RGrwT2R/t6A4o2szBMt/eKUj/kSQ837cI?=
 =?us-ascii?Q?IjN1h03CxWtvrkCzMnAUvhW5yuAfZvdCiMtoJvZKpT5hoOyrAUfaxgkQO/Cf?=
 =?us-ascii?Q?2/6Mn6y/vvq1SlhWC0dSPBc2XQOmRPujzrzObu49Ld8BKuY5YxgcZ/hUxvst?=
 =?us-ascii?Q?oJ7JlwCSlXCnfXWUhI/MfhBQiaFZw3CRdZRLyUiswndgEqSYbYjUikIa91WQ?=
 =?us-ascii?Q?ARfOYGWRh6JamcxC0w8duYmXQywQRi8e1HZQMoFiANsc0aaNrF4nq1qPvDvg?=
 =?us-ascii?Q?6RYKXH9xZVm3/yFCIaf1fT4q8jE7ykAx6umnSQGTWKNO2Ne6VRCuQkUyv5Pg?=
 =?us-ascii?Q?ZApqBA5UopzJoGuBaWFFK9o6M+zl5HNSFqrRk++Ek+Up1ySGsj3JdSGVdvVy?=
 =?us-ascii?Q?d8Olv4OKUoSfGqgEg7qCtch7N5lqA5SEn13XSizF0O/3kiE0SM10GraNNBiH?=
 =?us-ascii?Q?GfxYEoqFE/XIrQ0k5P64GOsw?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c36ce010-633b-47db-d39b-08d932ca6f9b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2021 02:32:08.7976
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: onR3J7t4OXczFg9K/Abos6L1eQ+EwWHSHA3F2XQp8tC66T5lDkmMyOPryYx2ryNzxG1yxF77czymTj8EkUNulhe6+7C20FNijpigN8yoEdk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4533
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10019 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2106190010
X-Proofpoint-ORIG-GUID: 9jXE-JIOyB08q1yEbxE5ZqlkM_gCD5W7
X-Proofpoint-GUID: 9jXE-JIOyB08q1yEbxE5ZqlkM_gCD5W7
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Nathan,

> clang warns:
>
> drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
> 'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                               (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
>                                ~~~~~~^~~
>
> buf is an array in the middle of a struct so deferencing it is not a
> problem as long as ctx is not NULL. Eliminate the check, which fixes the
> warning.

Applied to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering