Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2101199pxj; Sat, 19 Jun 2021 03:00:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzqQuOuDybY052RUJtONotgzaHc1tx96rNejuyWp4j2AOSJEDP8/qiflRdnvXjJHrJ0FBJu X-Received: by 2002:a5d:87c4:: with SMTP id q4mr11047092ios.141.1624096813790; Sat, 19 Jun 2021 03:00:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624096813; cv=none; d=google.com; s=arc-20160816; b=e5aC2/Le+MImssfx3un+se9EMeOG+S61Tcplu/deNcy6hi23KBRFsQgJnX/tYgFkc3 fFY0pjnLVqWtq/L6sq+vE82wtbTsN2s2wBz6jE4QnSVxXTXm4UGy4/LloSiXUgYaRi2X BcguKgfKg/D9Y/PkQquowIeMI07lsvc5/mtqMoEnAqOIUamBikrbrhNUMq3HDSKls2N/ N6Hya7bAqXcHGV0jp9DuAU9oVc/DK/5F3l7VCTqL5KJFi2k7GxD+OS2+vHMghZYBCDTW wzpjxClu2FxVbAnfevpdQtxJ54W9D20xyunejdpAGQesyhc1FFYuHd1/WTU8crHzM+Sr dlsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ocSpxz71TA5lK3q0byfIuoC7AgcSNqrnmhvLjFrEqD8=; b=m9LmLc7HLai9+dhrWAlwOodKMj+QZscx4ogrThFX78RGyCnHwmdWHgiItLoubRkpTe l+y/TGh2HbXxmukOK7+fLTqrxZF+VWBcqBQWcqL9ZT83JHShDxqy10Bxvihhoroq4ItH 9C9yCB9Jc+zTh7dmSuI0D9tIpwUZTwygd1GSltcqDTKyZURLUvWwHsFBw4GGndZoGj2O 0eiHWo0TaC6QPCAQENfgNlDNb4eVA8QMROcdjCiSF8aaoAb/TVTZsrKGgC0GD15twq8h by22i8wi2e6aBZ96fHbiYhl1n/9lWrNWb2TncXRvMQXza+Dz08A+n0gcQmxKxwny5p7C SdgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@vivo.com header.s=default header.b=ijhSRQm3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c15si4467617ilo.97.2021.06.19.03.00.00; Sat, 19 Jun 2021 03:00:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@vivo.com header.s=default header.b=ijhSRQm3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234115AbhFSGqc (ORCPT + 99 others); Sat, 19 Jun 2021 02:46:32 -0400 Received: from mail-m17639.qiye.163.com ([59.111.176.39]:14480 "EHLO mail-m17639.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232371AbhFSGq0 (ORCPT ); Sat, 19 Jun 2021 02:46:26 -0400 DKIM-Signature: a=rsa-sha256; b=ijhSRQm3e+Qu/7+WEz5PrdiyJeemGfVCH0gQGLss80cc+vvwLzOsdfH5O2+SYJJzQakizQ2JppPC4a+zYv6mlwRfg4Uw5TRBKGSAeM9V7wpWjvBXTVlPZIIL/5ahPS938kjsddo0b4fQqj4Q8kVh2awda+fywqycZvDnGHk6jBk=; s=default; c=relaxed/relaxed; d=vivo.com; v=1; bh=ocSpxz71TA5lK3q0byfIuoC7AgcSNqrnmhvLjFrEqD8=; h=date:mime-version:subject:message-id:from; Received: from ubuntu.localdomain (unknown [36.152.145.181]) by mail-m17639.qiye.163.com (Hmail) with ESMTPA id CD5E4380158; Sat, 19 Jun 2021 14:44:14 +0800 (CST) From: Bernard Zhao To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Bernard Zhao Subject: [PATCH 4/4] drm/radeon: delete useless return values Date: Fri, 18 Jun 2021 23:43:48 -0700 Message-Id: <20210619064349.26676-5-bernard@vivo.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210619064349.26676-1-bernard@vivo.com> References: <20210619064349.26676-1-bernard@vivo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZQ0seHlZNTU1DTkoZSR5IQk1VEwETFhoSFyQUDg9ZV1kWGg8SFR0UWUFZT0tIVUpKS0 hKTFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Ok06Cxw5Sj8THUIiKxUiTRhW FE4KCxpVSlVKTUlPS0NOS05OSU9MVTMWGhIXVRkeCRUaCR87DRINFFUYFBZFWVdZEgtZQVlITVVK TklVSk9OVUpDSllXWQgBWUFIS0NINwY+ X-HM-Tid: 0a7a230345ead994kuwscd5e4380158 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function radeon_fence_driver_init always returns success, the function type maybe coule be changed to void. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/radeon/radeon.h | 2 +- drivers/gpu/drm/radeon/radeon_fence.c | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 56ed5634cebe..8a15f490a390 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -384,7 +384,7 @@ struct radeon_fence { }; int radeon_fence_driver_start_ring(struct radeon_device *rdev, int ring); -int radeon_fence_driver_init(struct radeon_device *rdev); +void radeon_fence_driver_init(struct radeon_device *rdev); void radeon_fence_driver_fini(struct radeon_device *rdev); void radeon_fence_driver_force_completion(struct radeon_device *rdev, int ring); int radeon_fence_emit(struct radeon_device *rdev, struct radeon_fence **fence, int ring); diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/radeon/radeon_fence.c index 0d8ef2368adf..b2ce642ca4fa 100644 --- a/drivers/gpu/drm/radeon/radeon_fence.c +++ b/drivers/gpu/drm/radeon/radeon_fence.c @@ -905,9 +905,8 @@ static void radeon_fence_driver_init_ring(struct radeon_device *rdev, int ring) * Not all asics have all rings, so each asic will only * start the fence driver on the rings it has using * radeon_fence_driver_start_ring(). - * Returns 0 for success. */ -int radeon_fence_driver_init(struct radeon_device *rdev) +void radeon_fence_driver_init(struct radeon_device *rdev) { int ring; @@ -917,8 +916,6 @@ int radeon_fence_driver_init(struct radeon_device *rdev) } radeon_debugfs_fence_init(rdev); - - return 0; } /** -- 2.31.0