Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2102848pxj; Sat, 19 Jun 2021 03:02:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNJxZf8AI4GUscgo44qQmWivfCnbBAyz8uAPu+ALPXaXMqzKgEVnXdyboSNQDTOHcXQauw X-Received: by 2002:aa7:c0ca:: with SMTP id j10mr2726084edp.256.1624096961186; Sat, 19 Jun 2021 03:02:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624096961; cv=none; d=google.com; s=arc-20160816; b=dArOH5ZZfLJjKiia+ERgYAQ5Tg7pYN8Ejp95M+nwh2ifWPiHSFsA4Z7TEvKPSgivoD 3ae4Jbeiq7oEHOz33Sp+yRc5XhATADqGN+0+mb/TTyIkY0G8wTDH+pt9LKiosQXPFNou 9Q+5mXvx3UPb8Q0usL0P8JkycGoTlamDCxwebKrZV9jVbf/mGL46tFDL1d2sz6JXGERt AiPcfkS3+AMQctFx0WIZOdzaCPhJeo41s9QXL+srXTeMfn8DCZ24wL/MbAFKkyyhFTwO n9fr/YycsrIkp3BbxkNknPHoy5TywPCdiF50I/ZZrevLKh4fVOYrrAvDmqTwb8RnGeZ7 GfGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=AyoRdZHhaAWRaDmLC0Gm/8XWEkcamGqHQ6rsDgfSrDA=; b=ytgodg7nRuFWm66WjzjmCyiJvHfg4VL3vcl95/iWfdWiyM+WiZbOQB+/AwjIYc2vmV V4Liiy6DPcJmki9/INMIlJbz4BwWID54/usi8+1uqphwv7DgbzXsGdTd0cIZnYt9cFfe Z7sEr+I1c3Qng8C6SZ2BLp8yEiBJDqpC/yiJS1QjXTcY7a5ayeWZtMY+9KJrr3gJnlH7 VFLT4kW5WXYr5TMsibOQ5+AB+g8TeI/DwHyYp3fQTwswLfZEyPyGFvkDmZsRWAorDKJr o8j/sL1MaRf5hNHWyIWjVKZIgDdRDsCHiD5uozBapYI06b4R1gCeY80tGpES7pi6IOiY Sn1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yh14si689706ejb.391.2021.06.19.03.02.18; Sat, 19 Jun 2021 03:02:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234078AbhFSHeF (ORCPT + 99 others); Sat, 19 Jun 2021 03:34:05 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:5045 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230217AbhFSHeE (ORCPT ); Sat, 19 Jun 2021 03:34:04 -0400 Received: from dggeme755-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G6S5z2ngbzXhSq; Sat, 19 Jun 2021 15:26:47 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by dggeme755-chm.china.huawei.com (10.3.19.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sat, 19 Jun 2021 15:31:52 +0800 From: Peng Li To: , , , , CC: , , Subject: [PATCH net-next 2/3] net: c101: replace comparison to NULL with "!card" Date: Sat, 19 Jun 2021 15:28:37 +0800 Message-ID: <1624087718-26595-3-git-send-email-lipeng321@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1624087718-26595-1-git-send-email-lipeng321@huawei.com> References: <1624087718-26595-1-git-send-email-lipeng321@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeme755-chm.china.huawei.com (10.3.19.101) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the chackpatch.pl, comparison to NULL could be written "!card". Signed-off-by: Peng Li --- drivers/net/wan/c101.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c index 94b852f..f33192e 100644 --- a/drivers/net/wan/c101.c +++ b/drivers/net/wan/c101.c @@ -307,7 +307,7 @@ static int __init c101_run(unsigned long irq, unsigned long winbase) } card = kzalloc(sizeof(card_t), GFP_KERNEL); - if (card == NULL) + if (!card) return -ENOBUFS; card->dev = alloc_hdlcdev(card); @@ -381,7 +381,7 @@ static int __init c101_run(unsigned long irq, unsigned long winbase) static int __init c101_init(void) { - if (hw == NULL) { + if (!hw) { #ifdef MODULE pr_info("no card initialized\n"); #endif -- 2.8.1