Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2104180pxj; Sat, 19 Jun 2021 03:04:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVMawdPq37GyUgrj+gpwhBTM0xsXBVlkOD7p7DLTDcainL/LNkP0+vk5wcBQ05vBYOVIL9 X-Received: by 2002:a92:4446:: with SMTP id a6mr10860210ilm.9.1624097095130; Sat, 19 Jun 2021 03:04:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624097095; cv=none; d=google.com; s=arc-20160816; b=hri8b6ofUZJhMGiLy0DxV3S9Fmz3spyh2isaISe8MYq11XkTw2EqeAlMbvCjNbZtwj qsmqfYQyoBWO5e8bhjweV0MVSnlAOupIOArm+q4r17mRK26RNHBodeHRBrCeltAefZdq C905+8Rwz1Xo9I5pBw/fOqK9BGR56Jda2d1R1ssh6ucOPnqu+oMcdwHHJ8Xpk7OPB3s+ gcMBYXSo9zarKkPK5LgmQtG9o3FjsYEoQC7kiwcXP/ejGvVVCkPvODMQB6oODzxODvj1 pw1y+sUxr7ljmD4nk2XIxkEfNQtoyg9P5zqkoHrsSMNoORsKcIlRupDt5PTusNukOMQU 4FHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=v+U7odfbFJQovsecU7GWc8bZHX2YJeBH6Eg6K0NB8gM=; b=u3bgeQqYAi6+uyACK/Ud1BEIiyeqzIDkEySDrFhkFqDG/2aiIKqEfSPO6xgcezBVoU QKArZcxsanH86gt9Sbh0e/6S6JciPNkQfwREeDQu7IaU0GUK+WGrUojyjCwxKShlQKN2 EUS0WKyNyYchXbr8EsZthfAGSZ3LsjENyVFtMZ1O/TRV8S0G1sQ3SHXZPEUfnjZbnYPP 8Wz75z9qerX/Dut35dJmxGV0ACAsH32JPVWhED8f+A2DqbPes0gYmf+UaW2BVfr7RGDI azg3MEdiq20UyORsUSnl+OICAFR+b+m1gqkflav9iXE0R2Z0sjnbwsR+mZRR6qfv6njJ ENgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Fl+4IBB7; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=TKZd+OX6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s5si13698546jam.86.2021.06.19.03.04.24; Sat, 19 Jun 2021 03:04:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Fl+4IBB7; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=TKZd+OX6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234120AbhFSIY4 (ORCPT + 99 others); Sat, 19 Jun 2021 04:24:56 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:33242 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233963AbhFSIYz (ORCPT ); Sat, 19 Jun 2021 04:24:55 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1624090963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v+U7odfbFJQovsecU7GWc8bZHX2YJeBH6Eg6K0NB8gM=; b=Fl+4IBB7n1c5fEc3KsVVeFX1RJWuf5GmifPMiOVdfYCjDLA5KCv+ZKyHrpGoiYKnW40/H8 00tnO18BD7BQGnZtLkH9Z/yo8Eduu1mh4GX0Nhj5GsWDY0+y2D7snLgaiMd1oz5Iuuw+pB 1/OSMpdPHD2jSCPwRyXPY/pVGQpIJtSWkbqrrrx9fv7WDVtaZH1XZHDgmJRTlxL8UUBuBK yNqNvEtewQiD1m/GscZaMAJkf1BfgrqG+hVuieodxwL1S2Tppf530XIRcF3Sc7Qbb/3MjD iv7JqVcMJGwruWXoWH22bILXrp0qOMPymz874eVxwEHNQrXVNqLCzKaiMLQLIA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1624090963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v+U7odfbFJQovsecU7GWc8bZHX2YJeBH6Eg6K0NB8gM=; b=TKZd+OX6JDIsX7c0GvSmeNjKLCmA1+djgPZB5Q3kS5vK8B1UzDR1A6jsGHQvPfLH3cTDLq RopOStLAQUaM5KBQ== To: Nicolas Saenz Julienne Cc: linux-rt-users@vger.kernel.org, frederic@kernel.org, mtosatti@redhat.com, LKML , Peter Zijlstra Subject: Re: [RFC 2/2] timers: Make sure irq_work is handled when no pending timers In-Reply-To: <87mtrmeqon.ffs@nanos.tec.linutronix.de> References: <20210610125945.558872-1-nsaenzju@redhat.com> <20210610125945.558872-2-nsaenzju@redhat.com> <87mtrmeqon.ffs@nanos.tec.linutronix.de> Date: Sat, 19 Jun 2021 10:22:43 +0200 Message-ID: <875yyae018.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 19 2021 at 00:47, Thomas Gleixner wrote: > On Thu, Jun 10 2021 at 14:59, Nicolas Saenz Julienne wrote: > As we since then made work queues RT aware and it's possible to queue > work from the irq_work IPI context, the obvious solution is to delegate > this to a work queue. > > If we do a proper analysis of the affected irq work callbacks then this > probably makes a lot of sense independent of RT. There are only a few > really urgent irq work items which need to be handled immediately in the > IPI. > > RT is special, but as we have demonstrated over time it's not _that_ > special. It just needs a proper analysis and a real good argument why > something has to be special for RT and does not fit into the common > case. Or to demonstrate that the common case approach of 'do it right > away' is pointless or even harmfull. I skimmed most of the ~40 irq_work instances. Most of them have no urgency at all. And out of those non-urgent cases the majority does not even have the requirement to run on the current CPU, so they can be pushed off to a global work queue which moves them away from NOHZ full CPUs completely. That has nothing to do with RT, that's a benefit in general. Thanks, tglx