Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zev Weiss <zweiss@equinix.com>
To:     Andrew Jeffery <andrew@aj.id.au>
CC:     "openipmi-developer@lists.sourceforge.net" 
        <openipmi-developer@lists.sourceforge.net>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
        "minyard@acm.org" <minyard@acm.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "tmaimon77@gmail.com" <tmaimon77@gmail.com>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "avifishman70@gmail.com" <avifishman70@gmail.com>,
        "venture@google.com" <venture@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tali.perry1@gmail.com" <tali.perry1@gmail.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "chiawei_wang@aspeedtech.com" <chiawei_wang@aspeedtech.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "benjaminfair@google.com" <benjaminfair@google.com>,
        "arnd@arndb.de" <arnd@arndb.de>, "joel@jms.id.au" <joel@jms.id.au>,
        "KWLIU@nuvoton.com" <KWLIU@nuvoton.com>
Subject: Re: [PATCH v4 08/16] ipmi: kcs_bmc: Decouple the IPMI chardev from
 the core
Thread-Topic: [PATCH v4 08/16] ipmi: kcs_bmc: Decouple the IPMI chardev from
 the core
Thread-Index: AQHXZJlOx+4tEFa7006+6O/7RaWCzA==
Date:   Fri, 18 Jun 2021 23:26:04 +0000
Message-ID: <20210618232603.GC9658@hatter>
References: <20210608104757.582199-1-andrew@aj.id.au>
 <20210608104757.582199-9-andrew@aj.id.au>
In-Reply-To: <20210608104757.582199-9-andrew@aj.id.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ioFoyzjWSSBZHSmHbhR/Gghvsqy2ptX271ieNkUk5FWgZ//roQp3N/GhPMcL?=
 =?us-ascii?Q?xL5VsOeMwKr1+UpBjlq1Vs9AEMCW5grFQONin0MlM2S+M8+gC0nY1alZ1rGg?=
 =?us-ascii?Q?YUv3QG+Cu9nl4Dz7isvGSdV5bK8G5GKgJ1MVvMXecA/OoQqQY/ZFFhBlrUuy?=
 =?us-ascii?Q?L6d0YXARvA/+DHWRPuHqU6T5N1Gspg2ZGk2AlJQmDypFnjCsxh+CFIKEd2Lb?=
 =?us-ascii?Q?YBRek3Tcp17SSxse2OnFgwuAc9LKUF+MP4FnuxgcqEZ1YC1d2j4nL0Qpl0qP?=
 =?us-ascii?Q?B5vt3gstEBpW7/fKGyPqreaCEWjxGxmpAmvMnrdYK8QQ9qwo5lLTwOAHMENH?=
 =?us-ascii?Q?J2Aa1y5PF9VVDlrFu8R/z1KrB66oTO+m8LJ0NaAL5mLB/GIqtSAkPu3+I982?=
 =?us-ascii?Q?ZQVMWnit/yVC7bAfZh+X14LaO5F6EkNusbrq4HO+nrygzyNGHXoQzrwZmX9W?=
 =?us-ascii?Q?l9TU6z1TaF2UXo33s6lvYX+8zTBaEFt95OpN3hUEdyZKc4gJUV2D065p2r/7?=
 =?us-ascii?Q?tTh5FGBdy8V1hl0r0SQzqDEFcQ7yUYfsSAyT02CuyKVABFnGFViUWb+6lqK5?=
 =?us-ascii?Q?8Ef3XREAMEOipuxvAck8CcMPDJTwxzjToGz6oObgNZ9+bEVbrtBfRbCr4hpR?=
 =?us-ascii?Q?/pdTOhJ1IEz0PBc9mae5AhaopRpDKnFoqLKehaE5Q1KAfABqmQXN8OulKRmh?=
 =?us-ascii?Q?G+0Xv5g9XL09MGtUb1L17vXOjCSgOrCaXHKsX0IFPkPfyGOe2oNtpFCjGBAQ?=
 =?us-ascii?Q?uMN2UgflH+e3HB5G+VPwC90dmBMmtUIYq2VMoxWXqrwroXB4aVm1c/0/Ntmj?=
 =?us-ascii?Q?ge6HSkzXbXIG3spTSOc7CHKn9J6Re5T41wblU5rYVvVn5QXql6NxyKnR303U?=
 =?us-ascii?Q?X0WqJTxdpctgc1axlbAVrzlufwNGfDCeM4P1MzVN40/sVE1EynzVPfGgaU9W?=
 =?us-ascii?Q?nEiIEM8EC02vd3UdRczmQABJo/RO5PuMHzwclQWwBXJG1jZdrmDubDe81i32?=
 =?us-ascii?Q?nCsrUVRbTcOY1WJXWu9TJEJa3XKrvWUAq4QkS0ylJd5brnqGm5ZCxNLYFN8+?=
 =?us-ascii?Q?vp6HaB53G6ey/qddEI9shcwhTkVWVY7RyLOXl78dvhDS+dW758t8LFfSgyuw?=
 =?us-ascii?Q?ox++/GWLOlryhd38vSSaID8LA0C0wCBj9Fu8UTIX2+vrByWPh5PNCOPfKMEC?=
 =?us-ascii?Q?kdoAKsteJK7snRV6u2fOcCqCLU1lfa2nQ0gSv7hXltYdzFjcQJSteBQ4s7MY?=
 =?us-ascii?Q?iS6PlDmYdjhqA5Xtz6jrS93ZSPOnWizuvOrNZRH5aU0hqPVssjITaV5ExFgC?=
 =?us-ascii?Q?0Vo0rTkeFp8j8Tfm4wyvo69g?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2C6197FE3601F941923E62DDDEE23977@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: equinix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR04MB0762.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52a42a0d-31ad-4bf0-3c16-08d932b07153
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2021 23:26:04.5789
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72adb271-2fc7-4afe-a5ee-9de6a59f6bfb
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uUf227+KpMHIMhImdCDKMYxHzZ6oSOib0mbxaPQtfxy+J9O9l2ftluVMPgsB2Yj4MDHf7FTaWw+2XnhNxEQGBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1212
X-Proofpoint-GUID: ZZ7ib3hHweYQCSrr_4OXnkKOrdAMQjuT
X-Proofpoint-ORIG-GUID: ZZ7ib3hHweYQCSrr_4OXnkKOrdAMQjuT
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-06-18_12:2021-06-18,2021-06-18 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0
 priorityscore=1501 malwarescore=0 spamscore=0 impostorscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 lowpriorityscore=0 clxscore=1015 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2106180136
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 08, 2021 at 05:47:49AM CDT, Andrew Jeffery wrote:
>Now that we have untangled the data-structures, split the userspace
>interface out into its own module. Userspace interfaces and drivers are
>registered to the KCS BMC core to support arbitrary binding of either.
>
>Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>---
> drivers/char/ipmi/Kconfig             | 13 +++++
> drivers/char/ipmi/Makefile            |  3 +-
> drivers/char/ipmi/kcs_bmc.c           | 80 +++++++++++++++++++++++++--
> drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 31 +++++++++--
> drivers/char/ipmi/kcs_bmc_client.h    | 14 +++++
> 5 files changed, 128 insertions(+), 13 deletions(-)
>

Reviewed-by: Zev Weiss <zweiss@equinix.com>