Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lecopzer Chen <lecopzer.chen@mediatek.com>
To:     <sean@mess.org>
CC:     <lecopzer.chen@mediatek.com>, <linux-kernel@vger.kernel.org>,
        <linux-media@vger.kernel.org>, <mchehab@kernel.org>,
        <yj.chiang@mediatek.com>
Subject: Re: [PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module
Date:   Sat, 19 Jun 2021 15:28:53 +0800
Message-ID: <20210619072853.25882-1-lecopzer.chen@mediatek.com>
In-Reply-To: <20210618162334.GA31513@gofer.mess.org>
References: <20210618162334.GA31513@gofer.mess.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

> On Tue, Jun 08, 2021 at 06:14:51PM +0800, Lecopzer Chen wrote:
> > The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and
> > default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m
> > since the type of MEDIA_DIGITAL_TV_SUPPORT is bool.
> 
> First of all, the distributions carrry dvb_core as a module, so clearly
> it possible to set DVB_CORE=m.
> 
> As far as I can see, if MEDIA_SUPPORT=m, then DVB_CORE=m. 
> 
> So it is possible.

Thanks for review.

After checking, It does change DVB_CORE=m if MEDIA_SUPPORT=m.

We had MEDIA_SUPPORT=y, thus misunderstood by 'default MEDIA_DIGITAL_TV_SUPPORT'.

Thanks again for figuring out this.


-Lecopzer