Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2471023pxj; Sat, 19 Jun 2021 13:23:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQffrC1xxhlI/D6iianJK9cK/sExNx0X5zdUFOqoU/YFYLdhqN277bNgealAC3RII3iOiH X-Received: by 2002:a6b:6b11:: with SMTP id g17mr13841159ioc.101.1624134193889; Sat, 19 Jun 2021 13:23:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624134193; cv=none; d=google.com; s=arc-20160816; b=mjWPzI5w2h98hA/spbvqjfXT9XvferuJC4c6+XkF4yHorcJ8CEt7iGTE0LSpw6SVVT wSNgcxIFOF3ITOKZXrScJJkYMR1h4UKrsT9iFfuLyYxbfMF8jObbq5sBIfPGfZ9ULEU5 2Ff9AmudZPR2PZiUcYhZVCF1E64EKHhREfwflqynXM0KFvyJUq5dguFfm6WW1VSLGePn 4YjpHmUIkfilo+Nu7JDOBBtrLOCSiKc21/pieQ/sKnbaE5vk7icchrF6QharbNf4P1z7 yqMHtbU5TI7h/pdwIcE/BRdVO+f4ygwVll8SKWrV0e2iA5RpBKujkyYBQ2MvwPMEkj1P JaFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=YPx4L/uttPzQVzcincn60ApUfFDpuJvdcZ2iLqQTPmU=; b=I5IU2IyaXQ/Rt3QBK7J0gcBja5skUbppzvFU4pH2un1xRIMoUM50BsXrGItNBFc1lX r+G9UxJH7w6NaIk0qkvlExdO05K5lPjVg4bfASCZ2wL/0dJDJeRBszpozTtk4/Ir1wLX 8oV4j84xvnIQ3uswD2eSvInVtrl13WvaZ6yhOkheo6qNLtnOPTaKsClCXwIdnF/4sYrc u0enNJBIg65+NheWTKsjKBhdW0RxQa/fYems8WctpnGkPa6VpE8hDP7NiynR76N8emS0 u+/iKV5/Pq90d6a4VEEdoq8+GsVMcwdptrwqoCzyQDloN/I9KlL58jKoLJ+a75vhPKWB MozQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w10si4966126jao.68.2021.06.19.13.23.01; Sat, 19 Jun 2021 13:23:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232981AbhFSKCC (ORCPT + 99 others); Sat, 19 Jun 2021 06:02:02 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:5049 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231241AbhFSKB5 (ORCPT ); Sat, 19 Jun 2021 06:01:57 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G6WNb4SRTzXh8y; Sat, 19 Jun 2021 17:54:39 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Sat, 19 Jun 2021 17:59:44 +0800 Received: from localhost.localdomain (10.67.165.24) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sat, 19 Jun 2021 17:59:44 +0800 From: Guangbin Huang To: , , , CC: , , , , Subject: [PATCH net-next 6/8] net: at91_can: add braces {} to all arms of the statement Date: Sat, 19 Jun 2021 17:56:27 +0800 Message-ID: <1624096589-13452-7-git-send-email-huangguangbin2@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1624096589-13452-1-git-send-email-huangguangbin2@huawei.com> References: <1624096589-13452-1-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Li Braces {} should be used on all arms of this statement. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang --- drivers/net/can/at91_can.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c index 394fc72d39ac..5d984a448de4 100644 --- a/drivers/net/can/at91_can.c +++ b/drivers/net/can/at91_can.c @@ -585,9 +585,9 @@ static void at91_read_mb(struct net_device *dev, unsigned int mb, reg_msr = at91_read(priv, AT91_MSR(mb)); cf->len = can_cc_dlc2len((reg_msr >> 16) & 0xf); - if (reg_msr & AT91_MSR_MRTR) + if (reg_msr & AT91_MSR_MRTR) { cf->can_id |= CAN_RTR_FLAG; - else { + } else { *(u32 *)(cf->data + 0) = at91_read(priv, AT91_MDL(mb)); *(u32 *)(cf->data + 4) = at91_read(priv, AT91_MDH(mb)); } @@ -1020,15 +1020,15 @@ static void at91_irq_err(struct net_device *dev) reg_sr = at91_read(priv, AT91_SR); /* we need to look at the unmasked reg_sr */ - if (unlikely(reg_sr & AT91_IRQ_BOFF)) + if (unlikely(reg_sr & AT91_IRQ_BOFF)) { new_state = CAN_STATE_BUS_OFF; - else if (unlikely(reg_sr & AT91_IRQ_ERRP)) + } else if (unlikely(reg_sr & AT91_IRQ_ERRP)) { new_state = CAN_STATE_ERROR_PASSIVE; - else if (unlikely(reg_sr & AT91_IRQ_WARN)) + } else if (unlikely(reg_sr & AT91_IRQ_WARN)) { new_state = CAN_STATE_ERROR_WARNING; - else if (likely(reg_sr & AT91_IRQ_ERRA)) + } else if (likely(reg_sr & AT91_IRQ_ERRA)) { new_state = CAN_STATE_ERROR_ACTIVE; - else { + } else { netdev_err(dev, "BUG! hardware in undefined state\n"); return; } -- 2.8.1