Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210617071027.60278-1-hexin.op@bytedance.com>
 <CAE-0n51T9ZGADCk6LaKJdnQwPvMCawSvjwUP+AF0hFohAFom0A@mail.gmail.com> <87wnqpdco2.ffs@nanos.tec.linutronix.de>
In-Reply-To: <87wnqpdco2.ffs@nanos.tec.linutronix.de>
From:   =?UTF-8?B?5L2V6ZGr?= <hexin.op@bytedance.com>
Date:   Sun, 20 Jun 2021 13:52:18 +0800
Message-ID: <CACKzwj=ZybyemyAJLcV0GOyPE+dQYz8r+tNvv67AaniJJg7tDA@mail.gmail.com>
Subject: Re: [External] Re: [PATCH] debugobjects: add missing empty function debug_object_active_state()
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Stephen Boyd <swboyd@chromium.org>,
        Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thomas Gleixner <tglx@linutronix.de> =E4=BA=8E2021=E5=B9=B46=E6=9C=8820=E6=
=97=A5=E5=91=A8=E6=97=A5 =E4=B8=8A=E5=8D=8812:47=E5=86=99=E9=81=93=EF=BC=9A
>
> On Fri, Jun 18 2021 at 22:03, Stephen Boyd wrote:
> > Quoting Xin He (2021-06-17 00:10:27)
> >> All other functions are defined for when CONFIG_DEBUG_OBJECTS
> >> is not set.
> >>
> >> Signed-off-by: Xin He <hexin.op@bytedance.com>
> >> ---
> >>  include/linux/debugobjects.h | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/include/linux/debugobjects.h b/include/linux/debugobjects=
.h
> >> index 8d2dde23e9fb..af0d73d8d29b 100644
> >> --- a/include/linux/debugobjects.h
> >> +++ b/include/linux/debugobjects.h
> >> @@ -99,6 +99,9 @@ static inline void
> >>  debug_object_free      (void *addr, const struct debug_obj_descr *des=
cr) { }
> >>  static inline void
> >>  debug_object_assert_init(void *addr, const struct debug_obj_descr *de=
scr) { }
> >> +static inline void
> >> +debug_object_active_state(void *addr, const struct debug_obj_descr *d=
escr,
> >> +                         unsigned int expect, unsigned int next) { }
> >
> > I suppose it's a landmine that may go off at some point, but this isn't
> > fixing anything that's broken at the moment, correct?
>
> The two users (RCU/i915) have it guarded with RCU/I915 specific config
> options which depend on CONFIG_DEBUG_OBJECTS.
>
> I have no problem with the patch per se, but it want's a proper use case.
>
> Thanks,
>
>         tglx
>
>
>

Yes, config options ensure that there will be no problems. But when
CONFIG_DEBUG_OBJECTS is not set, we should provide all empty
functions that may be used.

Thanks.