Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: m2RkeRndped622VIzKJ0guDzs9xUo9uwNfhZNgpD/k5T4v2hSpOLjih6GH4P64LxnVpAnMJ217
 jh5qtEs1VYRL+uzHs3MuC7ho2KrbA/B88eVLgdSwdqFO6IKj5uF16XIHZYpQjokWjArMnsna8m
 Vnmm0/ZgQQGSxD/M7h5DzQ8ACMh556tjuelBYp2j95imq49rfDDIDWAcHu/0ggUmGMAV+tI6z5
 eW8a42XFICl4D6CKn/BKpSN8nXM1JzD4Caq8VhazKwL5N46+d+26M3GJAWaBiUsr4Uk4hLPrYI
 QFE=
IronPort-PHdr: A9a23:M800dxa/N8frER5DTfC9UWz/LTEz0IqcDmcuAnoPtbtCf+yZ8oj4O
 wSHvLMx1Q6PBt6FoKsd1qL/iOPJYSQ4+5GPsXQPItRndiQuroEopTEmG9OPEkbhLfTnPGQQF
 cVGU0J5rTngaRAGUMnxaEfPrXKs8DUcBgvwNRZvJuTyB4Xek9m72/q99pHOZwhEnjSwbL1zI
 Rm5sAndq8kbipZ+J6gszRfEvmFGcPlMy2NyIlKTkRf85sOu85Nm7i9dpfEv+dNeXKvjZ6g3Q
 qBWAzogM2Au+c3krgLDQheV5nsdSWoZjBxFCBXY4R7gX5fxtiz6tvdh2CSfIMb7Q6w4VSik4
 qx2UxLjljsJOCAl/2HWksxwjbxUoBS9pxxk3oXYZJiZOOdicq/BeN8XQ3dKUMRMWCxbGo6zY
 IUPAOgBM+hWrIfzukUAogelCAmwGO/i0CNEimPq0aA41ekqDAHI3BYnH9ILqHnbrtT1NaYSU
 eCoy6nD0DbMb/NM1jf89YPFdRAgoPCMXb1qcMrd1VUjGg3eg1WNtYPlJSmZ2foQvGiG9udtU
 /+khGE7pQ9ruDev2tsshZfThoIT0l3J+iF0zYI1KNO2VkJ2btqpHpRTuiyVOYZ7Qs0vTn1pt
 Ssmy7ALt522cDUXxZg6xBPSdfKKfoeL7x/+WuicPCt1iXR4c7y8nxa/6VasxvH4W8Wu01tHr
 jBJnsfRun0NzRDf9NSLRud780y8wziAzRrT5ftBIU0skKrbLIMuzaAom5oItETDAjf2mELrj
 K+Kbkkk+van6+DgYrj+o5+TLY50igXnPqQ2lcyzHP00MgYQU2SH5eiwzrLj/Ur+QLVFiv05j
 LPVv4zdJcQevqK5AglV3Zg/6xunETuqzNAVkWMEIV9FYh6LkZXlNlHULPzmEfuzn0ygkDJxy
 PDHOr3hDI/NLn/GkLr5fbd86k5cxxAyzdxD+55ZBKoMIO/vVU/rrtDXEAI2MxGsz+b9FNp9z
 p8eWX6IAqKBNKPSsFmI5v8gIuWVZ48apiz9K/476P7qlnI5h1Adcrez3ZcNa3C3AO5mI0OHb
 nromNsBFn0KvgVtBNDt3XGHUCJJdj6OWLg75TE8FsryAYLCWpq8xqCGxiC4HppITm9DA1GIV
 3zvctPXde0LbXejI91hjztMZ7ioSsd1xAOuvQ6ik+FPM+HOvCAUqMSwh5BO++TPmERqpnRPB
 MOH3jTIFjks9l4=
IronPort-HdrOrdr: A9a23:1x45VayZH6rlYxdxYQr3KrPwF71zdoMgy1knxilNoNJuA7Wlfq
 GV7YwmPHDP+VMssR0b6LK90ey7MBDhHP1OgLX5X43SODUO0VHAROpfBMnZowEIcBeOkdK1u5
 0QFZSWy+ecMbG5t6zHCcWDfOrICePqnpyVuQ==
MIME-Version: 1.0
References: <CABvMjLRxy1yqXUOWqTTeq=UOsLtuPAyOSCi4SPgcbAqjMuWCCg@mail.gmail.com>
 <YM7NzYgEl8NhU36H@google.com> <YM7RkI8fvpkfwAGA@google.com> <YM7ToLeaDajmBiwi@google.com>
In-Reply-To: <YM7ToLeaDajmBiwi@google.com>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Sat, 19 Jun 2021 23:00:59 -0700
Message-ID: <CABvMjLTP+Vh0cTDLU72Q-64f4DWQAp8-7DZ9GTBtoiqnKsaChA@mail.gmail.com>
Subject: Re: [PATCH] Input: hideep - fix the uninitialized use in hideep_nvm_unlock()
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Anthony Kim <anthony.kim@hideep.com>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Dimitry:

Sorry for the inconvenience, I would build the changes next time.
Thanks for your help : )

On Sat, Jun 19, 2021 at 10:35 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> On Sat, Jun 19, 2021 at 10:26:40PM -0700, Dmitry Torokhov wrote:
> > On Sat, Jun 19, 2021 at 10:10:37PM -0700, Dmitry Torokhov wrote:
> > > On Wed, Jun 16, 2021 at 03:48:51PM -0700, Yizhuo Zhai wrote:
> > > > Inside function hideep_nvm_unlock(), variable "unmask_code" could
> > > > be uninitialized if hideep_pgm_r_reg() returns error, however, it
> > > > is used in the later if statement after an "and" operation, which
> > > > is potentially unsafe.
> > >
> > > I think this is pretty sensible, but let's see if the original author
> > > has some comments...
> >
> > I guess not. Oh well...
> >
> > Applied, thank you.
>
> Note that I had to make some changes to make it compile. Please next
> time try building your changes before posting them,
>
> Thanks.
>
> --
> Dmitry


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside