Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 20 Jun 2021 08:52:22 +0200
Message-ID: <s5hsg1duixl.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Elia Devito <eliadevito@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Kailang Yang <kailang@realtek.com>,
        Jeremy Szu <jeremy.szu@canonical.com>,
        Hui Wang <hui.wang@canonical.com>,
        Jian-Hong Pan <jhp@endlessos.org>,
        Chris Chiu <chris.chiu@canonical.com>,
        Huacai Chen <chenhuacai@kernel.org>,
        Sami Loone <sami@loone.fi>,
        Werner Sembach <wse@tuxedocomputers.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Improve fixup for HP Spectre x360 15-df0xxx
In-Reply-To: <20210619204105.5682-1-eliadevito@gmail.com>
References: <20210619204105.5682-1-eliadevito@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 19 Jun 2021 22:41:04 +0200,
Elia Devito wrote:
> 
> On HP Spectre x360 15-df0xxx, after system boot with plugged headset, the
> headset mic are not detected.
> Moving pincfg and DAC's config to single fixup function fix this.
> 
> Signed-off-by: Elia Devito <eliadevito@gmail.com>

Oh, this was an unintended bug.  The actual fix isn't about moving two
things into one fixup, but rather dropping the superfluous chain to
ALC269_FIXUP_THINKPAD_ACPI.

Now applied with some more comments (and Cc to stable).  Thanks.


Takashi