Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2803883pxj; Sun, 20 Jun 2021 01:23:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7xpZVjwyumlmXnvmEaDfIGrr/Jh/RyjAyjQLai3eUkYc7qlQ8QqojXeL4hbMQ17J5bpVY X-Received: by 2002:a05:6402:5256:: with SMTP id t22mr15196836edd.54.1624177437409; Sun, 20 Jun 2021 01:23:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624177437; cv=none; d=google.com; s=arc-20160816; b=TvqTRnctHhMtwzvy8TKQu4OpN8LJt2V3v/syb/EgvPXvidw+QgXsrtVSvlizvSqI+2 TvfWgoFyDHHSIxpX2QU4HeFZgVmRG/PpNAb+juduQz6VkWuR3bk4/V+OsDGP7L3lXBUv W/0X6Ffjo/7d0QyIOJAdKooINe22JM3c9mx1tuyZp7eMpmfq6e5rxgUjYuCH6AXCWdRu xCcYQThA8Et/EQwkx+dyoCuEvqatTJkKEJ5/4U4mmUODXRn/3sVkX20IDea9QsYMOScO 81ZZhwBTjJ/ByKoQlA+45CxtBaAir0vhx67wDJ+7OC930fw/KM7QyxHzPV5dwgqEggbB jzRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=OUc+NRzMlLiPCAdXbLSXmgZKOLO4C4Ms3MHVtGkdG5s=; b=SqIuga9Q/9gK6bVkYQdkiJZNIzm2sXZPiZTJOLjNeTG1sgxh5gZWD6oz+tB4OcJpsw TW3FpShTtEf+wRYaAJVo0QUK/Yc5lKfGd2HxBf2zH/jZ2XCL6GStFI/CPKk+tYIgCad/ +rIps0UEphcEvmtzYMdOqC6xKy2AqK9F58qy/LelFnSXM9nGcBl3caQhvr8j79Jf1l2Q t7JA6lPSj6JLcLcWf6Yp8s9KC4mxdg8+2EfnJJCnWLFrLjqu2y+Ra0whZf5KAqk5otyc xYGE8gtStW61kEOHaQ8uJ+6XPTYmgTIeGVVP+ixfpAm1iL8GpsEccX8mQcE8TmxxdFv/ JXqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hg13si7000357ejc.98.2021.06.20.01.23.33; Sun, 20 Jun 2021 01:23:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229558AbhFTIXr (ORCPT + 99 others); Sun, 20 Jun 2021 04:23:47 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:46578 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbhFTIXr (ORCPT ); Sun, 20 Jun 2021 04:23:47 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d48 with ME id KLMY2500921Fzsu03LMYf0; Sun, 20 Jun 2021 10:21:33 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 20 Jun 2021 10:21:33 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: fabioaiuto83@gmail.com, gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, marcocesati@gmail.com, insafonov@gmail.com, hdegoede@redhat.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] staging: rtl8723bs: Fix an error handling path Date: Sun, 20 Jun 2021 10:21:31 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'ret' is known to be 0 at this point. It must be set to -ENOMEM if a memory allocation occurs. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by: Christophe JAILLET --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index 149d3b6e44d0..692d69de20cb 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -420,8 +420,10 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, wep_key_len = wep_key_len <= 5 ? 5 : 13; wep_total_len = wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, KeyMaterial); pwep = kzalloc(wep_total_len, GFP_KERNEL); - if (!pwep) + if (!pwep) { + ret = -ENOMEM; goto exit; + } pwep->KeyLength = wep_key_len; pwep->Length = wep_total_len; -- 2.30.2