Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3197461pxj; Sun, 20 Jun 2021 13:10:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzu/dv4Zlkm1IINtEf0sUQ/rpC9Cp+DpzptHMgn7FAPNke7S7HII92B0blz69pAp7cdLbGP X-Received: by 2002:a05:6402:158d:: with SMTP id c13mr17392033edv.182.1624219813555; Sun, 20 Jun 2021 13:10:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624219813; cv=none; d=google.com; s=arc-20160816; b=aXVgKPdKVYWmo5/VZbbtSLdHti05t4eMcBowFxzkG42UVXMBrkIDYRwnYSj+6RoIb9 YBocql3PaurSbMb/pjacpeQwZ7CTG3lcodVK3S1EXcAWCwwT9eOYAR3L8NDQGl69fPcr rqrtfwrbSrLtD3sb762gWS/NQ27auh1Lw2UW76l+u2eJwCHmGoWQ/04GsrZ7kHhJv2Ai NjWNGI+BcvCnFK1EaPy1IqKcCY9Q0VPKYNRvXzjfVPCFZT5KNCJOK40M4+shIxnIw8ux 8mLwxGEK6y1vF0Sp3SbxJrBfw1GzvRkmIi0+vZt+zCVDK0V9QWmKeTCjRUEoKVoqxe5u HQGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject:dkim-signature; bh=K6hP8zxpxK6evZOXHpF0z21aotgESEZI1DXffVp/DBY=; b=ukTBMTDQH4OlOre9w3rrNjM6diXRa4r+ThN2deVq1FoVnIytAbs9PXxQsNmR3PLU5d YEgYP4fwcK9OUY74l2Qvb5bHJB0E5tHiVr/88yG24HQAmmmBhKOuZtpdR0XAkp0n9ngk SLUwL0dkyFXAhujzGxYvaIxTILknExOzkAni9IaKhVzBZShImsxu+zjRuEEabDUXHshw tq5ToLk9QSQQ5YHvH44yO0ywjljqL9bwbfJzhKZpsIBJJEoGB09l/LlsxhfX+QF6qTki hZvB+bmB7U1+duFZqa6Vi1eT+LpTEn2wWOF4s3vnai9PdY+jtkG32JOU3vasjDn/jCf5 kHrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YC898T3S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y11si4254212edt.45.2021.06.20.13.09.51; Sun, 20 Jun 2021 13:10:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YC898T3S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbhFTULK (ORCPT + 99 others); Sun, 20 Jun 2021 16:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbhFTULK (ORCPT ); Sun, 20 Jun 2021 16:11:10 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37AA5C061574; Sun, 20 Jun 2021 13:08:57 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id c9so17194262wrt.5; Sun, 20 Jun 2021 13:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=K6hP8zxpxK6evZOXHpF0z21aotgESEZI1DXffVp/DBY=; b=YC898T3SQGIirS1uD8L0AnCX+DWO4XWC68WnN2GjV9aNqSnTq/P15BYRYoHhXgbpRy ynipamEhRPZDNSaOjM2IYDUTwjXjf5uIvq6l9W108ShDpfwRzjtz8p2B6zkeCnJt6hR0 chRg6nDYprd3+Y+sakEFiyMacATfnAmnpMbKDbU5nzBAl4MSLAeOfAhi4Ciliu/Tw/pG I3JJJpNOEkO1ltDDBVjN5GWCoSfbD9rMlHosK7DcFBFAKzsO1VxV5gmiRc+0w9y46gsv G/vo5Ff/695Ot8EkAOYJPzv8YMN8M7EGRQ86Fn7llmO/xXXduIX2earZeU2nXqCJ7Nqt 2PMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K6hP8zxpxK6evZOXHpF0z21aotgESEZI1DXffVp/DBY=; b=Zdjn0bDXkiBSdaUUB1WunwjUoYQTMDwPhrOZvhYyO0HuT2kkYvIrIf8afnDD2hly/9 sx2tCiYz5NBYQZ3TF6L1EaWyy9eZt9ztpPL4np+3GBSRMmSPylSKPDl5PHQmv+KlKUJ4 H6zkpU3tMxLq6xl/AoTcSOFb9ePWSRhkvELGxAjSdQY9kDKSQdLiNH13nWV4qEGR4rQT NlGo1qo604f+bSxzj3V7tmK/FuhaFDHJSVSXBt7LPRhGaBRzzXYAxni+IPYzNE/YPUjH Ws3McYtqyVWsg1pPy5QFMoXST+JaIuPORdfUscuslvQcaznywQo1S/GnCOb2UguINQud YqQQ== X-Gm-Message-State: AOAM533dKxOeWsH9QvzKBk0+267SOPs6DRw74BPzDXs41e+YbhEcsXFA Hh4GoWdRgJJnKdx5OeOb3C3njwnN3M3VmQ== X-Received: by 2002:a5d:6485:: with SMTP id o5mr24229204wri.91.1624219735538; Sun, 20 Jun 2021 13:08:55 -0700 (PDT) Received: from [192.168.8.197] ([185.69.145.72]) by smtp.gmail.com with ESMTPSA id d15sm15038687wri.58.2021.06.20.13.08.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Jun 2021 13:08:55 -0700 (PDT) Subject: Re: [PATCH v2] io_uring: reduce latency by reissueing the operation To: Randy Dunlap , Olivier Langlois , Jens Axboe , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <4578f817-c920-85f1-91af-923d792fc912@infradead.org> From: Pavel Begunkov Message-ID: <7ad30cb0-3322-6c40-2a1b-27308aa757d8@gmail.com> Date: Sun, 20 Jun 2021 21:08:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <4578f817-c920-85f1-91af-923d792fc912@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/20/21 9:01 PM, Randy Dunlap wrote: > On 6/20/21 12:28 PM, Olivier Langlois wrote: >> On Sun, 2021-06-20 at 12:07 -0700, Randy Dunlap wrote: >>> On 6/20/21 12:05 PM, Olivier Langlois wrote: >>>> -               return false; >>>> +               return ret?IO_ARM_POLL_READY:IO_ARM_POLL_ERR; >>> >>> Hi, >>> Please make that return expression more readable. >>> >>> >> How exactly? >> >> by adding spaces? >> Changing the define names?? > > Adding spaces would be sufficient IMO (like Pavel suggested also). Agree. That should be in the code style somewhere -- Pavel Begunkov