Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3208700pxj; Sun, 20 Jun 2021 13:35:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwh6G6wx+J96yZnuHsVUgr9RLTOPQT/SFrnGwVd50gtaHBANM5KEwVWELFFuwqsZYL18Mhg X-Received: by 2002:a5d:94ce:: with SMTP id y14mr17898173ior.67.1624221344933; Sun, 20 Jun 2021 13:35:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624221344; cv=none; d=google.com; s=arc-20160816; b=SyQGo9cFDemd50nBjeISQldmJneEkfrgqkOMgfkcalbQybA6UrHGNeJycOi2fwTJVA H3NuPk+vUQQpVYC+C6tIAKpwPa29hm9UbwCnnx9NIK96bGOuacZj7SHzpiyhGvMrh8dr Vf3HD/IgxuMtKf5RXMl+2x8Rd+xVbfKPhoHXiruMCU+/i4SqnAFx2gG2z1zT2kaFQO9e gISOs3jKwa078zHN79TIinXcUkGKF9rUl4RLnsm9+xjxPnUt/vVkdnN/3c58mHvkiUYt Hy3ArqiQAt4ui1oglsl9kj+JxWG3PVQbPZplI3il0Kmd5HPimQTqgEtjnutO8xDP2A+M Plew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=002hc5rDYIUO1n8I98sr06RNJWOrTDwpNg4V8Wm28z8=; b=KyjE7dN7TWmSzZAKvYP2OAsG2Dinwc/Th1m3LR5iOqc1Nwdv/RYpyEhDo+wkACpokN ZC+WPIIL/Aa29Tj/FqvtCwwcnbjiPc6lOajiZM6b+Q3NLDaGhCdYbIwSBAu8Cx774LRV hunwXE/c1aCZAJZcjlmcGJzFioyt/2hCgDbg1mOfNbepqYcmti9ArbF601fwnahl1oZj L1OQv+YRCWoHi8iOPc9O29BRtPkaEgQUegJWIS2QQ8X8XG+xTQnzC0fXiZuLBpxWf20T yc5aEO7mxiJSdUwPSfaQYr4SCc5BqoSne6xGDIEetnea3aiqptDSkm4Y7pfO+UxDcpNV SFBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l16si17200233ion.65.2021.06.20.13.35.29; Sun, 20 Jun 2021 13:35:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230031AbhFTUfn (ORCPT + 99 others); Sun, 20 Jun 2021 16:35:43 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:57085 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbhFTUfl (ORCPT ); Sun, 20 Jun 2021 16:35:41 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 8383B240008; Sun, 20 Jun 2021 20:33:26 +0000 (UTC) From: Alexandre Belloni To: Colin King , linux-rtc@vger.kernel.org, Alessandro Zummo Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] rtc: v3020: remove redundant initialization of variable retval Date: Sun, 20 Jun 2021 22:33:23 +0200 Message-Id: <162422118505.1090685.17421473715592582970.b4-ty@bootlin.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210609120050.185746-1-colin.king@canonical.com> References: <20210609120050.185746-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Jun 2021 13:00:50 +0100, Colin King wrote: > The variable retval is being initialized with a value that is never read, > it is being updated later on. The assignment is redundant and can be > removed. Applied, thanks! [1/1] rtc: v3020: remove redundant initialization of variable retval commit: fc3c335226a92f69aa01061e66b60ace88475dd3 Best regards, -- Alexandre Belloni