Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 21 Jun 2021 04:55:12 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Qing Zhang <zhangqing@loongson.cn>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Rob Herring <robh+dt@kernel.org>,
        Huacai Chen <chenhc@lemote.com>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        netdev@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH 1/4] stmmac: pci: Add dwmac support for Loongson
Message-ID: <YM//kGGAp3vz8OYb@lunn.ch>
References: <20210618025337.5705-1-zhangqing@loongson.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210618025337.5705-1-zhangqing@loongson.cn>
Precedence: bulk

> +static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> +{
> +	struct plat_stmmacenet_data *plat;
> +	struct stmmac_resources res;
> +	int ret, i, mdio;
> +	struct device_node *np;
> +
> +	np = dev_of_node(&pdev->dev);
> +
> +	if (!np) {
> +		pr_info("dwmac_loongson_pci: No OF node\n");
> +		return -ENODEV;
> +	}
> +
> +	if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
> +		pr_info("dwmac_loongson_pci: Incompatible OF node\n");
> +		return -ENODEV;
> +	}
> +
> +	plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL);
> +	if (!plat)
> +		return -ENOMEM;
> +
> +	if (plat->mdio_node) {
> +		dev_err(&pdev->dev, "Found MDIO subnode\n");

It is an error is an MDIO node is found?

> +		mdio = true;
> +	}
> +

...

> +
> +	plat->phy_interface = device_get_phy_mode(&pdev->dev);
> +	if (plat->phy_interface < 0)
> +		dev_err(&pdev->dev, "phy_mode not found\n");
> +
> +	plat->interface = PHY_INTERFACE_MODE_GMII;

Seems odd you call device_get_phy_mode() but then have this hard coded
PHY_INTERFACE_MODE_GMII?

	Andrew