Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Saurav Kashyap <skashyap@marvell.com>
To:     SeongJae Park <sj38.park@gmail.com>
CC:     Javed Hasan <jhasan@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "himanshu.madhani@oracle.com" <himanshu.madhani@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        SeongJae Park <sjpark@amazon.de>
Subject: RE: [EXT] [PATCH] scsi: bnx2fc: Remove meaningless
 'bnx2fc_abts_cleanup()' return value assignment
Thread-Topic: [EXT] [PATCH] scsi: bnx2fc: Remove meaningless
 'bnx2fc_abts_cleanup()' return value assignment
Thread-Index: AQHXZGFW/m6s108dKEO3/NZ6aDBFWasd8fYQ
Date:   Mon, 21 Jun 2021 05:23:10 +0000
Message-ID: <DM6PR18MB30345324649F1B1E05082970D20A9@DM6PR18MB3034.namprd18.prod.outlook.com>
References: <20210618164514.6299-1-sj38.park@gmail.com>
In-Reply-To: <20210618164514.6299-1-sj38.park@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5Kh2aNon/I8JbzdDKfXXha3wdXbF3XfTjxtwdOI+rG/kpErHLTZpyxxqg6Nm?=
 =?us-ascii?Q?DNF3OPBbBRUiZtw/Qf1DvcQYZx0tLvU5toOX3hclyhOr+akM23z6161JIzbX?=
 =?us-ascii?Q?iL7cN8oDcI/SYtvu5HWZWSu8pe8+mOxEJ4oHOkw0w03zGRtSnOPLouWxHkUJ?=
 =?us-ascii?Q?o00o0Tc8D6yGFw+tL1rCW7AH7j1G77obl+EXINLKjCBMdevTkz5q+hTQX7jX?=
 =?us-ascii?Q?jVbwyaix3Jw7H30iuq7Rv04IhPH9B96BCK27tjn6aJHHK/HWytMqJVpupYhK?=
 =?us-ascii?Q?ag6tV2TiI7pYlA5EipgHDvMiU4KLso9oOAqO4gUqR8mwrKKzGqa0uLG75W4s?=
 =?us-ascii?Q?/VunYZ7WMXqjkXxyreC5mBOdWFYmOL8U9S7SidwxB2TJfRvMkSGrT0WimQLl?=
 =?us-ascii?Q?rfCKwr0OXnvd7EoWCA4d9CKMl8P/uVd0if6OQ8vKKmGFKRguiYyCcc7cO/Ck?=
 =?us-ascii?Q?Qnuax3w/yX6QcwObmLDZ1oMwXhNwwxC2S4rKj+rfVSQjt4q0ViIIkleAzfiH?=
 =?us-ascii?Q?Q/HJB9z7Ev95DkbsZppL2OXoDQCMloACssh2RDWMbs6NOd2BpBhbQHTadCK9?=
 =?us-ascii?Q?YaOLpYsmaSw6wmcQ2RU+OU+yJKSiC4dNsKg5SBXE2yAfE9HAM1FcBM7lP7tT?=
 =?us-ascii?Q?lBzrVET5P+Vbv1bSDASjVOTWH1rvhrPOGOcsZNoDTuGZu3FaUkV02qXK+Vc8?=
 =?us-ascii?Q?LXKk6g3Zy2y45Tj0esqlaW4JnNRqB1N+h3agUScxRXY2/QoL9o+eX8aFkMgo?=
 =?us-ascii?Q?TnM5AUsGKjdxBIIFGVeqeD8uh3GnhJU2RVFaVNzGyBh2MCS94cCsve+NOMEL?=
 =?us-ascii?Q?IU9DqdXfMyuMCm9mv4yLKDjzwDVyhsLp671xTfu7Q/FjjAyg2/OtS2FUd2pX?=
 =?us-ascii?Q?OA3sLj8ssUdYmU4+6X/5vDc2+pcSxNk+I4xKqroHJufqf38sukR2/ym3NHXu?=
 =?us-ascii?Q?8ttk6iV7/2BMgQKaMU982Kw7ET+ngecb5K96ilzGoTCgz/tOgVv3tFo14cWV?=
 =?us-ascii?Q?CNSXHM8PA2i+vMniIsg/Pqfjt8PYnzT0CeQIxW8+VzWgcUSuuvYec8+ggiYk?=
 =?us-ascii?Q?4HBvr+zgDn56N0D8a9/JDDJtLilWd9JaVb4DJsWvZZgWgYxx7ACWAbQ6p3Xh?=
 =?us-ascii?Q?JKVmx9QteHhOcBfTPOtencMfzQdh/Cmf40vej7nGVPimgzH2c6lZIUBFamKp?=
 =?us-ascii?Q?88PECaaTGmcb8J6tbIRUOT77yXgAu6f0xjtPDOcSino+pTi79zA587t+LtuJ?=
 =?us-ascii?Q?uF2w/M2jQAnmHpU1ShPaVNteeTO7fujAhADY1ErBwxjVQetY5g4/EKnMrhF/?=
 =?us-ascii?Q?LIQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB3034.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e881f63a-cef9-4243-77ea-08d93474a8de
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2021 05:23:10.2179
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x2aDj9cHqpj5fkIqbScMPNQBgZF10T+O8JvctTTAsqrZgxXBqNICZrSpWQETjOWhTh2+3qVtwd0yAWx7z8E+ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3035
X-Proofpoint-GUID: eABGIRwQPbsFBudGMlv_oM8ilsb_Teki
X-Proofpoint-ORIG-GUID: sS9PNEQGuNlnOJqr05dX7IiEDNf6bQbo
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-06-21_01:2021-06-20,2021-06-21 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi SeongJae,

> -----Original Message-----
> From: SeongJae Park <sj38.park@gmail.com>
> Sent: Friday, June 18, 2021 10:15 PM
> To: Saurav Kashyap <skashyap@marvell.com>
> Cc: Javed Hasan <jhasan@marvell.com>; GR-QLogic-Storage-Upstream <GR-
> QLogic-Storage-Upstream@marvell.com>; jejb@linux.ibm.com;
> martin.petersen@oracle.com; himanshu.madhani@oracle.com; linux-
> scsi@vger.kernel.org; linux-kernel@vger.kernel.org; SeongJae Park
> <sjpark@amazon.de>
> Subject: [EXT] [PATCH] scsi: bnx2fc: Remove meaningless
> 'bnx2fc_abts_cleanup()' return value assignment
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> From: SeongJae Park <sjpark@amazon.de>
>=20
> Commit 122c81c563b0 ("scsi: bnx2fc: Return failure if io_req is already
> in ABTS processing") made 'bnx2fc_eh_abort()' to return 'FAILED'
> when 'io_req' is alrady in ABTS processing, regardless of the return
> value of 'bnx2fc_abts_cleanup()'.  But, it left the assignment of the
> return value of 'bnx2fc_abts_cleanup()' to 'rc', which is meaningless
> now.  This commit removes it.
>=20
> This issue was discovered and resolved using Coverity Static Analysis
> Security Testing (SAST) by Synopsys, Inc.
>=20
> Fixes: 122c81c563b0 ("scsi: bnx2fc: Return failure if io_req is already i=
n ABTS
> processing")
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
>  drivers/scsi/bnx2fc/bnx2fc_io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc=
_io.c
> index ed300a279a38..f2996a9b2f63 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
> @@ -1213,7 +1213,7 @@ int bnx2fc_eh_abort(struct scsi_cmnd *sc_cmd)
>  		 * cleanup the command and return that I/O was successfully
>  		 * aborted.
>  		 */
> -		rc =3D bnx2fc_abts_cleanup(io_req);
> +		bnx2fc_abts_cleanup(io_req);
>  		/* This only occurs when an task abort was requested while
> ABTS
>  		   is in progress.  Setting the IO_CLEANUP flag will skip the
>  		   RRQ process in the case when the fw generated SCSI_CMD
> cmpl

Acked-by: Saurav Kashyap <skashyap@marvell.com>

Thanks,
~Saurav=20
> --
> 2.17.1