Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "M Tamseel Shams" <m.shams@samsung.com>
To:     <kgene@kernel.org>, <krzk@kernel.org>,
        <gregkh@linuxfoundation.org>, <jslaby@suse.com>
Cc:     <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <alim.akhtar@samsung.com>, <ajaykumar.rs@samsung.com>
In-Reply-To: <20210621044757.40046-1-m.shams@samsung.com>
Subject: RE: [PATCH v4] serial: samsung: change to platform_get_irq_optional
Date:   Mon, 21 Jun 2021 10:56:45 +0530
Message-ID: <000801d7665e$08424a00$18c6de00$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQLrt4vOvQgF3TDEnmyTfCXOmtgdwgF+I3k8qOlbpbA=
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <CGME20210621044400epcas5p40368077e77d2da219db8f890dfd69f7c@epcas5p4.samsung.com>
        <20210621044757.40046-1-m.shams@samsung.com>
Precedence: bulk


> -----Original Message-----
> From: Tamseel Shams <m.shams=40samsung.com>
> Sent: Monday, June 21, 2021 10:18 AM
> To: kgene=40kernel.org; krzk=40kernel.org; gregkh=40linuxfoundation.org;
> jslaby=40suse.com
> Cc: linux-arm-kernel=40lists.infradead.org; linux-samsung-soc=40vger.kern=
el.org;
> linux-serial=40vger.kernel.org; linux-kernel=40vger.kernel.org;
> alim.akhtar=40samsung.com; ajaykumar.rs=40samsung.com; Tamseel Shams
> <m.shams=40samsung.com>
> Subject: =5BPATCH v4=5D serial: samsung: change to platform_get_irq_optio=
nal
>=20
> In few older Samsung SoCs like s3c2410, s3c2412 and s3c2440, UART IP is h=
aving
> 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210, exynos5433, and exynos4210
> UART is having only 1 interrupt line. Due to this, =22platform_get_irq(pl=
atdev, 1)=22
> call in the driver gives the following false-positive error:
> =22IRQ index 1 not found=22 on recent platforms.
>=20
> This patch replaces the platform_get_irq() call with
> platform_get_irq_optional() and hence avoiding the false-positive error.
>=20
> Signed-off-by: Tamseel Shams <m.shams=40samsung.com>
> ---
> Commit message is changed.
> Addressed Krzysztof's previous comment.
>=20
>  drivers/tty/serial/samsung_tty.c =7C 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsun=
g_tty.c
> index 6ef614d8648c..c44582011b9b 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> =40=40 -1911,7 +1911,7 =40=40 static int s3c24xx_serial_init_port(struct
> s3c24xx_uart_port *ourport,
>  		ourport->tx_irq =3D ret + 1;
>  	=7D
>=20
> -	ret =3D platform_get_irq(platdev, 1);
> +	ret =3D platform_get_irq_optional(platdev, 1);
>  	if (ret > 0)
>  		ourport->tx_irq =3D ret;
>  	/*
> --
>=20

Please ignore this patch.
Sorry for the spam.

Thanks & Regards,
Tamseel Shams