Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210620134954.15233-1-Christine.Zhu@mediatek.com> <20210620134954.15233-4-Christine.Zhu@mediatek.com>
In-Reply-To: <20210620134954.15233-4-Christine.Zhu@mediatek.com>
From:   Tzung-Bi Shih <tzungbi@google.com>
Date:   Mon, 21 Jun 2021 14:11:23 +0800
Message-ID: <CA+Px+wXG=KDRKzm-bS95tnmpbBTCD3C72nhi3RJGw6PG6Cj-hQ@mail.gmail.com>
Subject: Re: [v1,3/3] watchdog: mt8195: add wdt support
To:     Christine Zhu <christine.zhu@mediatek.com>
Cc:     linux@roeck-us.net, robh+dt@kernel.org, wim@linux-watchdog.org,
        matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        seiya.wang@mediatek.com, linux-watchdog@vger.kernel.org,
        rex-bc.chen@mediatek.com,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        srv_heupstream@mediatek.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jun 20, 2021 at 9:50 PM Christine Zhu
<Christine.Zhu@mediatek.com> wrote:
> add support for watchdog device found in MT8195 SoC
Please write complete sentences.  For example, "Supports MT8195
watchdog device."

> Change-Id: Ib2434cf2d47a2e14916056f08a4fc630569624ed
Remove the unneeded tag.

> +static const struct mtk_wdt_data mt8195_data = {
> +       .toprgu_sw_rst_num = MT8195_TOPRGU_SW_RST_NUM,
> +};
Expect to see the of_device_id (i.e. mtk_wdt_dt_ids) has the newly
introduced compatible string and use the mt8195_data but failed to
find it.