Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3500723pxj; Sun, 20 Jun 2021 23:21:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEU9AZzIOkZtBM14Uj8pdM136Jjy/XlwHF3I1Trf5FEUtkfkMPNiXZcdtwToNEJeuh0zfQ X-Received: by 2002:a05:6602:1304:: with SMTP id h4mr17989361iov.180.1624256463674; Sun, 20 Jun 2021 23:21:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624256463; cv=none; d=google.com; s=arc-20160816; b=xOMOKAbzkiZxYTtyqGxpNF56mpIxSqnw7nkIC9YYrFUXpEvECqYg6rTxlTj6YGjSTb PxmRymYeXFr5QB0bvMNyt2EkyUE/UtBwJ25AQWOQjC2NkbRbvQY1pN8ee59yMv0hG4Wi mnyJMwbrgl2Q7xJsxt9FgubYI18XBzEmkX56S+ToPHebJEXoi2O4+ZUCs5hUik6/3zI4 p47VLB2Qm9q5YJFel6GYns8I3lxO67xmby1YSSY6xoc6KhrX7FbHNbaMq6e8UjB5I/JW FTiTRNvk5AGZ333dQe94qdb3Uehmdt5a447pUIo04+Q3FZ3jVb7Nznz/KK8fWruZA46h dQSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uNPhX10VS4Wsxa/3lttySqU/Lgh5QfKb1rKtABFNOog=; b=f6z6AtHBkR5xLzw7VHE51lwOR4tqBIeZkDUWA5Izpgg0mOv65JIlCWL1+ztfdgSDb/ HFm9WzpTLNKkVG+HOl4PtYQDpADuaHOIXdgz0/U9BuE0NPG8h5I/m7zK4b9w4WKzHLfm i5Ta2GmaPYGSI6IPGn2/SR/P3m21XIYjlYVg49ICvYh64SG7bXJStj/wlN2YJ0UY0ggY 32qfP31ukmuGbKxA3f+DQGlxuZ+AIzIbj3li/Z6remD6uNBoT08K8jU8VJZWf9yR59K4 PqGW6LEExGXurS7aHFsV+IrgNuynuD5T9e+yxC99I8uNYGKoC9cXLV1gAL8lGCEWw7yF JU6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=tmomkpjo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w11si11235395ilq.104.2021.06.20.23.20.51; Sun, 20 Jun 2021 23:21:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=tmomkpjo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229710AbhFUGWR (ORCPT + 99 others); Mon, 21 Jun 2021 02:22:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbhFUGWQ (ORCPT ); Mon, 21 Jun 2021 02:22:16 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7677C061574; Sun, 20 Jun 2021 23:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uNPhX10VS4Wsxa/3lttySqU/Lgh5QfKb1rKtABFNOog=; b=tmomkpjoveAIKFsL8pIBCHEUwD H14nWK8xQ4Kney+2ABTK3OjwIGIEcJdPFbCe9+CDvys+GTxzgPjt+ekmhwpgquzErPv7VY7Yy8Zu/ FI96nEO8MHf1RDnSNtF3qRGf5kJBhG5qV/TRZyEzmEGkoahawJsQh4lDZvvzTUshUTgY4jpVZcsLu Sy7vlLqjMrXb+szCktDbdxBje6RAvqLQ0QaUKNA9cFnt8m7rEauUwjtPW5l5rivVHWUiKoGiJMJxC hjkfWXGJeGg8qIARfV/4zoI2wnGpzH9Qqz/mkyOXFt3gl5jVAjdrJR31WHFhBCzB/B6c07/bIVMFr qrPfJ+Cw==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvDGi-00CmTX-Eo; Mon, 21 Jun 2021 06:18:59 +0000 Date: Mon, 21 Jun 2021 07:18:48 +0100 From: Christoph Hellwig To: Tetsuo Handa Cc: hch@infradead.org, axboe@kernel.dk, desmondcheongzx@gmail.com, gregkh@linuxfoundation.org, linux-block@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, richard@nod.at, Shuah Khan , syzbot+6a8a0d93c91e8fbf2e80@syzkaller.appspotmail.com, vigneshr@ti.com Subject: Re: [PATCH v2] block: genhd: don't call probe function with major_names_lock held Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The obvious fix is to not call unregister_blkdev under loop_ctl_mutex. Which is pretty pointless anyway - I have a series to fix that but it might need some reordering to move this to the front.