Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424293AbWKJALg (ORCPT ); Thu, 9 Nov 2006 19:11:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1424291AbWKJALg (ORCPT ); Thu, 9 Nov 2006 19:11:36 -0500 Received: from smtp.osdl.org ([65.172.181.4]:62376 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1424286AbWKJALf (ORCPT ); Thu, 9 Nov 2006 19:11:35 -0500 Date: Thu, 9 Nov 2006 16:11:23 -0800 From: Andrew Morton To: =?ISO-8859-1?Q? "C=E9dric?= Augonnet" , Anton Vorontsov Cc: "Alan Stern" , "Benoit Boissinot" , "Mattia Dongili" , "USB development list" , "Kernel development list" , "SCSI development list" Subject: Re: [linux-usb-devel] 2.6.19-rc5-mm1 Message-Id: <20061109161123.f9cea1e7.akpm@osdl.org> In-Reply-To: References: <20061109192658.GA2560@inferi.kami.home> <20061109145100.01d6ec46.akpm@osdl.org> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2045 Lines: 64 On Fri, 10 Nov 2006 00:39:46 +0100 "C__dric Augonnet" wrote: > 2006/11/9, Andrew Morton : > > > > > hm. Maybe it's the disk_sysfs_symlinks() changes. > > > > Could someone who can reproduce this please try this revert, on > > 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1? > > > > > > > > fs/partitions/check.c | 5 +++-- > > 1 files changed, 3 insertions(+), 2 deletions(-) > > > > diff -puN fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal fs/partitions/check.c > > --- a/fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal > > +++ a/fs/partitions/check.c > > @@ -416,7 +416,7 @@ static char *make_block_name(struct gend > > > > static int disk_sysfs_symlinks(struct gendisk *disk) > > { > > - struct device *target = disk->driverfs_dev; > > + struct device *target = get_device(disk->driverfs_dev); > > int err; > > char *disk_name = NULL; > > > > @@ -452,8 +452,9 @@ err_out_dev_link: > > sysfs_remove_link(&disk->kobj, "device"); > > err_out_disk_name: > > kfree(disk_name); > > - } > > err_out: > > + put_device(target); > > + } > > return err; > > } > > > > _ > > > > - > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > Hi, > > This patch seems to be working : whereas i had the same oops as Mattia > each time I unplugged my USB external DD drive, now it does not happen > anymore. > Thank you very much for this one ! > OK, thanks. I dropped the patch. So ide-cs will now start deadlocking again. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/