Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3508368pxj; Sun, 20 Jun 2021 23:36:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtgR7+1XktcjUTgU93xk9DGnhp1Rnxz4VWRztxaZN+S/0nEA3GmoS/UUb34/oDwMrSFzfY X-Received: by 2002:a50:fd83:: with SMTP id o3mr16119994edt.95.1624257384138; Sun, 20 Jun 2021 23:36:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624257384; cv=none; d=google.com; s=arc-20160816; b=hoXhfD5qzg0kvkp55UxNxoxHONeO9Gny50ZqgRg+PPFTqu1uqgd1ZFU52i8ln2wpXc O5I0qL+m9oQUZiWJZaDmm96OZ9owmQEDhZRXR1kALv+4fK/csI+5T+0+SPQ14RHwdZp/ K4B6foFUE7HNdJAcrFIv8PVFWhG6O0ebYgGmZcB8LZPv0b/lVrCDclfIwje7hwZxXt7I 8GDgb7TH7CE/sbLH4iiAx0cTB5RRArZjiOD+aCx6H9AB9QWZV2nvpkVT7ClmaCKM8htG GuJrzj9O3isJ56mq2diS8VY0yOKKXSxNjW4Pwm7XGQCSvkNtKtmxI7bQp4Ze6aOCrwky TyIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aCanFyp0v2jOrrETqt0KjmgWAWBjl0NKdX2BO8yPJao=; b=bo1CtOqo6fYKFmnt3cwZ33MOeml7oNTYDa6udA1MUrOXqLTW+niakXQATEe/3uXXxY XlCOWjGmUe6yf2KNzb/40gR0YeSzgzuHTvBfaLwaludcdMUn3SLk9q69t2EcP50fpAm9 CYCuBpgc/Fzy88hzdGh7AI6SIehNGwZi8pncJxwOZqf0ZTpdRnGOwTa2I+jJqQxSFXkF XthG+a/BFnAsR0Z2hF8aFEoM0/sP8ai4dSIupd3SsC3gQ7So4eU8PXS+Fmer3G2rIHg2 46/3P06LoFmfe8XiCagjGeYS48KUcS5aYK9sVPfYb5IfluT0mlmP7u9zFEhHPHLZj1LJ v/5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Kkq/6Ie9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 24si17998009edv.190.2021.06.20.23.36.02; Sun, 20 Jun 2021 23:36:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Kkq/6Ie9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbhFUGf3 (ORCPT + 99 others); Mon, 21 Jun 2021 02:35:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:33814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFUGf3 (ORCPT ); Mon, 21 Jun 2021 02:35:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E3ADD61003; Mon, 21 Jun 2021 06:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624257195; bh=4CHyizIg9hIDQpvR1sUF6YvkzCW5f0Mg81yRETpYfxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kkq/6Ie9xmSIeYZ0BVM7Kn12lEiK5wWTTUy2Odxg1XrCVA+Q+hve3E65qUukWEYUe C8Dl6tQm6Rol0GPks9qonx7BJW/+0hqC5DdNEXmxJZ6AsGqeRwefPV/gX370AQemD3 0uNSntOyUmMJiY8Sztli/cHhWZcb1Z1AfFmIB20chdT3s2wYxMr7ErNKHnPXqczFsH HU2l7bp3nonEjEipvrdzq013S10bwUrXSagUO8w8CzNWXBpcYAEE5cCC/FhqIc/YSV Vdl3DxaXC2mQpVvkpTDBGTsfFqKnf0Ig5T55bG9lQKL3etV57yzSjk3RV/HIerC2CX tHIn22z54zpvg== Date: Mon, 21 Jun 2021 12:03:12 +0530 From: Vinod Koul To: Kunihiko Hayashi Cc: Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Jassi Brar Subject: Re: [PATCH] phy: uniphier-pcie: Fix updating phy parameters Message-ID: References: <1623037842-19363-1-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623037842-19363-1-git-send-email-hayashi.kunihiko@socionext.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07-06-21, 12:50, Kunihiko Hayashi wrote: > The current driver uses a value from register TEST_O as the original > value for register TEST_I, though, the value is overwritten by "param", > so there is a bug that the original value isn't no longer used. > > The value of TEST_O[7:0] should be masked with "mask", replaced with > "param", and placed in the bitfield TESTI_DAT_MASK as new TEST_I value. Applied, thanks -- ~Vinod