Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: RE: [PATCH v11 08/12] scsi: ufshpb: Add "Cold" regions timer
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Daejun Park <daejun7.park@samsung.com>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Bart Van Assche <bvanassche@acm.org>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        Zang Leigang <zangleigang@hisilicon.com>,
        Avi Shchislowski <Avi.Shchislowski@wdc.com>,
        Bean Huo <beanhuo@micron.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
In-Reply-To: <DM6PR04MB6575C466A26C5FEB5EEE5B6FFC0A9@DM6PR04MB6575.namprd04.prod.outlook.com>
Message-ID: <1796371666.41624261202246.JavaMail.epsvc@epcpadp3>
Date:   Mon, 21 Jun 2021 16:33:10 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
References: <DM6PR04MB6575C466A26C5FEB5EEE5B6FFC0A9@DM6PR04MB6575.namprd04.prod.outlook.com>
        <20210616112800.52963-9-avri.altman@wdc.com>
        <20210616112800.52963-1-avri.altman@wdc.com>
        <1891546521.01624253881548.JavaMail.epsvc@epcpadp4>
        <CGME20210616112925epcas2p1267d33aee5fa552333a0503207e262f2@epcms2p8>
Precedence: bulk

Hi Avri,

> > Hi Avri,
> > 
> > >diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
> > >index 39b86e8b2eee..cf719831adb3 100644
> > >--- a/drivers/scsi/ufs/ufshpb.c
> > >+++ b/drivers/scsi/ufs/ufshpb.c
> > 
> > ...
> > 
> > >+static void ufshpb_read_to_handler(struct work_struct *work)
> > >+{
> > >+        struct ufshpb_lu *hpb = container_of(work, struct ufshpb_lu,
> > >+                                             ufshpb_read_to_work.work);
> > >+        struct victim_select_info *lru_info = &hpb->lru_info;
> > >+        struct ufshpb_region *rgn, *next_rgn;
> > >+        unsigned long flags;
> > >+        LIST_HEAD(expired_list);
> > >+
> > >+        if (test_and_set_bit(TIMEOUT_WORK_RUNNING, &hpb-
> > >work_data_bits))
> > >+                return;
> > >+
> > >+        spin_lock_irqsave(&hpb->rgn_state_lock, flags);
> > >+
> > >+        list_for_each_entry_safe(rgn, next_rgn, &lru_info->lh_lru_rgn,
> > >+                                 list_lru_rgn) {
> > >+                bool timedout = ktime_after(ktime_get(), rgn->read_timeout);
> > >+
> > >+                if (timedout) {
> > >+                        rgn->read_timeout_expiries--;
> > >+                        if (is_rgn_dirty(rgn) ||
> > >+                            rgn->read_timeout_expiries == 0)
> > >+                                list_add(&rgn->list_expired_rgn, &expired_list);
> > 
> > Why we need additional expired_list for updating inactive information?
> Since the lru list is accessed under rgn_state_lock, 
> and inactivation is done under rsp_list_lock,
> It's just a convenient way to list all the expired  regions.
OK,

>  
> > And I think "rgn->list_lru_rgn" should be deleted when it is expired.
> Oh - I don't think so.
> This should be done in one place only, which is cleanup_lru_info,
> Which is called, in host mode, after a successful unmap request.

Then I think list_for_each_entry_safe can be changed to list_for_each_entry,
because there is no deletion of the list. But it doesn't look like it needs
a fix right now.

Thanks,
Daejun