Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: RE: [PATCH v11 12/12] scsi: ufshpb: Make host mode parameters
 configurable
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Daejun Park <daejun7.park@samsung.com>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Bart Van Assche <bvanassche@acm.org>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        Zang Leigang <zangleigang@hisilicon.com>,
        Avi Shchislowski <Avi.Shchislowski@wdc.com>,
        Bean Huo <beanhuo@micron.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
In-Reply-To: <DM6PR04MB6575BF2A411BDDF7832A844AFC0A9@DM6PR04MB6575.namprd04.prod.outlook.com>
Message-ID: <2038148563.21624261202059.JavaMail.epsvc@epcpadp3>
Date:   Mon, 21 Jun 2021 16:25:10 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
References: <DM6PR04MB6575BF2A411BDDF7832A844AFC0A9@DM6PR04MB6575.namprd04.prod.outlook.com>
        <20210616112800.52963-13-avri.altman@wdc.com>
        <20210616112800.52963-1-avri.altman@wdc.com>
        <2038148563.21624252502579.JavaMail.epsvc@epcpadp3>
        <CGME20210616113004epcas2p41cf111449e118965ae71aaaee1d3bd5c@epcms2p4>
Precedence: bulk

Hi Avri,

> > Hi Avri,
> > 
> > >diff --git a/Documentation/ABI/testing/sysfs-driver-ufs
> > b/Documentation/ABI/testing/sysfs-driver-ufs
> > >index d001f008312b..b10cecb286df 100644
> > >--- a/Documentation/ABI/testing/sysfs-driver-ufs
> > >+++ b/Documentation/ABI/testing/sysfs-driver-ufs
> > >@@ -1449,7 +1449,7 @@ Description:        This entry shows the maximum
> > HPB data size for using single HPB
> > >
> > >                 The file is read only.
> > >
> > >-What:                /sys/bus/platform/drivers/ufshcd/*/flags/wb_enable
> > >+What:                /sys/bus/platform/drivers/ufshcd/*/flags/hpb_enable
> > 
> > This part seems to be the problem with my patch. I will correct it.
> Maybe if just another spin is really required?
OK, I will fix it in next re-spin and update the patches.
  
> > 
> > ...
> > 
> > >diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
> > >index ab66919f4065..6f2ded8c63b0 100644
> > >--- a/drivers/scsi/ufs/ufshpb.c
> > >+++ b/drivers/scsi/ufs/ufshpb.c
> > 
> > ...
> > 
> > >@@ -1697,6 +1704,7 @@ static void
> > ufshpb_normalization_work_handler(struct work_struct *work)
> > >         struct ufshpb_lu *hpb = container_of(work, struct ufshpb_lu,
> > >                                              ufshpb_normalization_work);
> > >         int rgn_idx;
> > >+        u8 factor = hpb->params.normalization_factor;
> > >
> > >         for (rgn_idx = 0; rgn_idx < hpb->rgns_per_lu; rgn_idx++) {
> > >                 struct ufshpb_region *rgn = hpb->rgn_tbl + rgn_idx;
> > >@@ -1707,7 +1715,7 @@ static void
> > ufshpb_normalization_work_handler(struct work_struct *work)
> > >                 for (srgn_idx = 0; srgn_idx < hpb->srgns_per_rgn; srgn_idx++) {
> > >                         struct ufshpb_subregion *srgn = rgn->srgn_tbl + srgn_idx;
> > >
> > >-                        srgn->reads >>= 1;
> > >+                        srgn->reads >>= factor;
> > >                         rgn->reads += srgn->reads;
> > 
> > How about changing it to "rgn->read >>=factor" and placing it outside the
> > for statement?
> I think zeroing rgn->reads before the loop and then rgn->reads += srgn->reads
> Making it clear, even as far as doc, that the region reads is the sum over its subregions.

OK, I understand your intention.

Thanks,
Daejun

>  
> Anyway, this code was introduced in patch 4, so I will fix it there only if you find it really necessary.
>  
> Thanks,
> Avri
>  
>  
>