Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1624023139-66147-1-git-send-email-vincent.donnefort@arm.com> <1624023139-66147-2-git-send-email-vincent.donnefort@arm.com>
In-Reply-To: <1624023139-66147-2-git-send-email-vincent.donnefort@arm.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Mon, 21 Jun 2021 10:40:08 +0200
Message-ID: <CAKfTPtA+myH9qGsN+khvfqUUMB4AK3+3d_x6xiYxV_p6hwYzgA@mail.gmail.com>
Subject: Re: [PATCH 2/2] sched/rt: Fix Deadline utilization tracking during
 policy change
To:     Vincent Donnefort <vincent.donnefort@arm.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Valentin Schneider <valentin.schneider@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 18 Jun 2021 at 15:32, Vincent Donnefort
<vincent.donnefort@arm.com> wrote:
>
> DL keeps track of the utilization on a per-rq basis with the structure
> avg_dl. This utilization is updated during task_tick_dl(),
> put_prev_task_dl() and set_next_task_dl(). However, when the current
> running task changes its policy, set_next_task_dl() which would usually
> take care of updating the utilization when the rq starts running DL
> tasks, will not see a such change, leaving the avg_dl structure outdated.
> When that very same task will be dequeued later, put_prev_task_dl() will
> then update the utilization, based on a wrong last_update_time, leading a
> huge spike in the DL utilization signal.
>
> The signal would eventually recover from this issue after few ms. Even
> if no DL tasks are run, avg_dl is also updated in
> __update_blocked_others(). But as the CPU capacity depends partly on the
> avg_dl, this issue has nonetheless a significant impact on the scheduler.
>
> Fix this issue by ensuring a load update when a running task changes
> its policy to DL.
>
> Fixes: 3727e0e ("sched/dl: Add dl_rq utilization tracking")
> Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 3829c5a..915227a 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -2497,6 +2497,8 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p)
>                         check_preempt_curr_dl(rq, p, 0);
>                 else
>                         resched_curr(rq);
> +       } else {
> +               update_dl_rq_load_avg(rq_clock_pelt(rq), rq, 0);
>         }
>  }
>
> --
> 2.7.4
>