Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3579398pxj; Mon, 21 Jun 2021 01:48:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiZCy0rRhqlkNwB0bbPeLUjT13Q9eDebbpovmTCprIa1FF9ut097PX9hOUmY1nTnnUFHt0 X-Received: by 2002:a05:6402:34d2:: with SMTP id w18mr19716624edc.292.1624265332614; Mon, 21 Jun 2021 01:48:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624265332; cv=none; d=google.com; s=arc-20160816; b=TFNZ3qgevlLQlPekxXvdji1MWGA6vRz8+nGVmPlfmgTFHcKxrI/3vxGXrlwCQ2Mq6F mTtnxkPKG3nEzDlng8EFJsELEspy31VY7iKOf7Gvc9hFusom6HUpnHARcP9+FnMADIQN d9iup9cDVYmImn9jmOgCkoykZzyiuH/fTl0XhNTjVGC9wI6/7QKczeWBGSd70T9KBiJu JiyXA92HP8pUu34n0RqU8qARokN2ZCI7f2D2dW7ZbaZ39AiJQYYu7I/887tjEiHwlkXP pmzHy3WcR4CMfCTMMbjbtPfL2U7f8eL+81IX9lyche2XqVrWwE+efqwLP9QFgkbSlJD+ fQ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=uXtdpap2XWVQM3NEM8tHgG7IZgx4gfDzJ3mSSoym7bQ=; b=hol9pTYdElC4q3oHXU2H7F4UPFFK0uIFAkFiPsLCwBYahbLA+SfrW2wmMmN2yAsPbI 28yJ2BaThMbuB2wV/UWYFcQvB0WcrYTZEqZwdroiKF3vP0+f5EY14g9gRhie0nwQxbci thCO05XT2zyhP9l6EU/cfW0luBTU8H0fYFy4rXTapNrLcr5cviPabpUpL3KcQBj9Ewo1 ukj9+I8okU9Bm04yOzjbekGMUKuUxT0g1CUSQJsgtEO+0U3Jk9JzN2krUplnNNkhgDdM Jgkmjm0aTG/BFOM+K1Ys8RV8k1qFLnfkBDlE9DCEdKy0gQv4uJ4r/GeD2wQWQgTZWvIk o61g== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=hQnIxvAO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g18si16331432edq.291.2021.06.21.01.48.30; Mon, 21 Jun 2021 01:48:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=hQnIxvAO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230318AbhFUItR (ORCPT + 99 others); Mon, 21 Jun 2021 04:49:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbhFUItQ (ORCPT ); Mon, 21 Jun 2021 04:49:16 -0400 Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B95C2C061756 for ; Mon, 21 Jun 2021 01:47:01 -0700 (PDT) Received: by mail-vk1-xa32.google.com with SMTP id l7so3564245vkk.2 for ; Mon, 21 Jun 2021 01:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uXtdpap2XWVQM3NEM8tHgG7IZgx4gfDzJ3mSSoym7bQ=; b=hQnIxvAO+GKOw5DtQZRyn+Ht3RUiPiiUOc1AEuz4qtakU0ufowvZk69wobzde8tdu5 dus5DWnhFKzZS7vlwyU6eqSvLLxil8zxsfTp2E3RgbxDdL6R4kLwzXE6mdccdtu8Jffu NS+ObbYojD8PrU+HsVCoZt8VTFQesY0GbloQE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uXtdpap2XWVQM3NEM8tHgG7IZgx4gfDzJ3mSSoym7bQ=; b=pe/eLZIKO4vbGmiYNgkEUBr+Lh4y+UpwyzAmN78yb37alWEGgvOSuoYgG3V5Uj0JrM 7x1X26TnFNGDH4IVApIoUaSXgSw4+aHgCmhFCqNU4INoSehUAHqwj0Xt76gxlwFuBAOA YIygbZ8Z22OnXezVQZ+ozW/fVgzSBSB5Vlhf7BX+ZoXL4Sb2cteu+z8zNDTIZRe4nXhf hKWor06pNy3FgZc8RV+PBmalOvQm3lj8CV4g4GoNCXZrJqpZNdZA/GcMYr3Hhr3/7P+3 hfv9q59BX1BwUnwh+QJVicOY0pBCpOdnU9hHbqmE+94kDG55191Y5D4OAmPFs3w335+C E5lg== X-Gm-Message-State: AOAM533JuoodI6OCuddZLrTH0qSJqMCZof3QHnU1hmN9xs7PVGpwgJQl BJz/cIvNxNT8+pct3lCOMhrT2R4rCNVgwUVX/U0MGg== X-Received: by 2002:ac5:c5c9:: with SMTP id g9mr4609680vkl.11.1624265220845; Mon, 21 Jun 2021 01:47:00 -0700 (PDT) MIME-Version: 1.0 References: <20210523065152.29632-1-yuehaibing@huawei.com> In-Reply-To: <20210523065152.29632-1-yuehaibing@huawei.com> From: Miklos Szeredi Date: Mon, 21 Jun 2021 10:46:49 +0200 Message-ID: Subject: Re: [PATCH -next] cuse: use DEVICE_ATTR_*() macros To: YueHaibing Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 23 May 2021 at 08:52, YueHaibing wrote: > > Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR, > which makes the code a bit shorter and easier to read. Sorry, I don't see really see the cleanup value of this patch. Thanks, Miklos